From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
f.fainelli@gmail.com, kernel@pengutronix.de
Subject: Re: [PATCH 2/3] net: ucc_geth: make probe consistently acquire a reference to the phy node
Date: Thu, 07 Aug 2014 16:07:24 -0700 (PDT) [thread overview]
Message-ID: <20140807.160724.1353005428981700895.davem@davemloft.net> (raw)
In-Reply-To: <1407448106-1819-2-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
Date: Thu, 7 Aug 2014 23:48:25 +0200
> When the driver attaches to a device that has a phy handle the probe
> routine returns with a reference to that node. This reference is
> correctly dropped in the error path and the remove function. In the
> fixed phy case however no reference is acquired and so the error path=
> might drop a reference the driver isn't holding. Fix that by getting =
a
> reference to the MAC.
> =
> Fixes: 87009814cdbb ("ucc_geth: use the new fixed PHY helpers")
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
Applied.
next prev parent reply other threads:[~2014-08-07 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 21:48 [PATCH 1/3] net: ucc_geth: drop acquired references in probe error path and remove Uwe Kleine-König
2014-08-07 21:48 ` [PATCH 2/3] net: ucc_geth: make probe consistently acquire a reference to the phy node Uwe Kleine-König
2014-08-07 23:07 ` David Miller [this message]
2014-08-07 21:48 ` [PATCH 3/3] net: ucc_geth: Don't use the MAC as PHY without a fixed link Uwe Kleine-König
2014-08-07 23:07 ` David Miller
2014-08-07 23:07 ` [PATCH 1/3] net: ucc_geth: drop acquired references in probe error path and remove David Miller
2014-08-08 20:34 ` Uwe Kleine-König
2014-08-08 20:52 ` David Miller
2014-08-10 18:32 ` [PATCH] net: ucc_geth: fix build failure Uwe Kleine-König
2014-08-11 4:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807.160724.1353005428981700895.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).