From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Shengjiu Wang <shengjiu.wang@freescale.com>
Cc: fabio.estevam@freescale.com, alsa-devel@alsa-project.org,
timur@tabi.org, arnd@arndb.de, shc_work@mail.ru, tiwai@suse.de,
Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz,
nicoleotsuka@gmail.com, broonie@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH V2 2/2] Revert "ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support."
Date: Thu, 7 Aug 2014 20:09:11 +0800 [thread overview]
Message-ID: <20140807120909.GA4153@MrMyself> (raw)
In-Reply-To: <5627d0f839900c33b1c15de4c21f745015d3e19d.1407403727.git.shengjiu.wang@freescale.com>
Hi Shengjiu,
On Thu, Aug 07, 2014 at 05:33:25PM +0800, Shengjiu Wang wrote:
> This reverts commit a603c8ee526f5ea9ad9b40710308766299ad8a69.
>
> fsl_asoc_xlate_tdm_slot_mask() will invert the mask, which isn't fit for
> esai. The default function snd_soc_xlate_tdm_slot_mask() is ok for esai.
You should describe why that doesn't fit for ESAI and what's the result
if keeping it.
Thank you,
Nicolin
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
> ---
> sound/soc/fsl/Kconfig | 1 -
> sound/soc/fsl/fsl_esai.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index f54a8fc..f3012b6 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -49,7 +49,6 @@ config SND_SOC_FSL_ESAI
> tristate "Enhanced Serial Audio Interface (ESAI) module support"
> select REGMAP_MMIO
> select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n
> - select SND_SOC_FSL_UTILS
> help
> Say Y if you want to add Enhanced Synchronous Audio Interface
> (ESAI) support for the Freescale CPUs.
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index f252370..b2f6b3e 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -18,7 +18,6 @@
>
> #include "fsl_esai.h"
> #include "imx-pcm.h"
> -#include "fsl_utils.h"
>
> #define FSL_ESAI_RATES SNDRV_PCM_RATE_8000_192000
> #define FSL_ESAI_FORMATS (SNDRV_PCM_FMTBIT_S8 | \
> @@ -612,7 +611,6 @@ static struct snd_soc_dai_ops fsl_esai_dai_ops = {
> .hw_params = fsl_esai_hw_params,
> .set_sysclk = fsl_esai_set_dai_sysclk,
> .set_fmt = fsl_esai_set_dai_fmt,
> - .xlate_tdm_slot_mask = fsl_asoc_xlate_tdm_slot_mask,
> .set_tdm_slot = fsl_esai_set_dai_tdm_slot,
> };
>
> --
> 1.7.9.5
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2014-08-07 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 9:33 [PATCH V2 0/2] refine esai for tdm support Shengjiu Wang
2014-08-07 9:33 ` [PATCH V2 1/2] ASoC: fsl_esai: refine esai for TDM support Shengjiu Wang
2014-08-07 9:33 ` [PATCH V2 2/2] Revert "ASoC: fsl-esai: Add .xlate_tdm_slot_mask() support." Shengjiu Wang
2014-08-07 12:09 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807120909.GA4153@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shc_work@mail.ru \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).