From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1blp0190.outbound.protection.outlook.com [207.46.163.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 14C291A0082 for ; Tue, 19 Aug 2014 17:41:22 +1000 (EST) Date: Tue, 19 Aug 2014 15:41:07 +0800 From: Shengjiu Wang To: Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA Message-ID: <20140819074103.GA5806@audiosh1> References: <53F22F5E.2090601@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <53F22F5E.2090601@metafoo.de> Cc: fabio.estevam@freescale.com, sfr@canb.auug.org.au, alsa-devel@alsa-project.org, timur@tabi.org, arnd@arndb.de, shc_work@mail.ru, tiwai@suse.de, Li.Xiubo@freescale.com, lgirdwood@gmail.com, perex@perex.cz, nicoleotsuka@gmail.com, broonie@kernel.org, xobs@kosagi.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Aug 18, 2014 at 06:52:46PM +0200, Lars-Peter Clausen wrote: > On 08/18/2014 10:38 AM, Shengjiu Wang wrote: > >Build kernel with SND_SOC_IMC_PCM_DMA=m && SND_IMX_SOC=n leads the following > >error: > > > > sound/built-in.o: In function `fsl_sai_probe': > >>>fsl_sai.c:(.text+0x5f662): undefined reference to `imx_pcm_dma_init' > > sound/built-in.o: In function `fsl_esai_probe': > >>>fsl_esai.c:(.text+0x6044b): undefined reference to `imx_pcm_dma_init' > > > >Most cpu driver in soc/fsl has use the function 'imx_pcm_dma_init' which is > >defined in imx-pcm-dma.c, so need to select SND_SOC_IMX_PCM_DMA, but it depends > >on SND_IMX_SOC, if SND_IMX_SOC=n, then SND_SOC_IMX_PCM_DMA will not be > >selected. > >So remove the dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA. > > > >Reported-by: kbuild test robot > >Signed-off-by: Shengjiu Wang > > Those if conditions where just added[1] by Arnd to avoid other build > failures. So just removing them again makes little sense. > > As far as I can see imx_pcm_dma_init() should be stubbed out when > SND_SOC_IMX_PCM_DMA is not selected. So what's going on here? > > [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ff40260f79dc0436604452bccd449bffd25ebafb > Lars-Peter Clausen & Arnd The purpose of Arnd's patch is same with me, which is to resolve the build error when SND_SOC_IMX_PCM_DMA=m & SND_SOC_FSL_SSI/SAI/ESAI/SPDIF=y, the error is "undefined reference to `imx_pcm_dma_init'". But Arnd's patch didn't involve this situation that SND_IMX_SOC=n & SND_SOC_IMX_PCM_DMA=m. Currently I think out a solution for this issue is to change select SND_SOC_IMX_PCM_DMA if SND_IMX_SOC != n to depends on SND_SOC_IMX_PCM_DMA != m How do you think about this? best regards Wang shengjiu