From: Anton Blanchard <anton@samba.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] powerpc: Move htab_remove_mapping function prototype into header file
Date: Fri, 12 Sep 2014 07:55:14 +1000 [thread overview]
Message-ID: <20140912075514.06703989@kryten> (raw)
In-Reply-To: <20140823012940.303e3ebc@canb.auug.org.au>
Hi Stephen,
> Please be consistent about "extern" use (unless this file is already
> inconsistent, I guess). (I know that the current trend is to remove
> "extern" in header files - I just happen to disagree with that
> trend. :-))
Good idea, fixed this for the next rev.
Anton
next prev parent reply other threads:[~2014-09-11 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 22:55 [PATCH 1/4] powerpc: Make a bunch of things static Anton Blanchard
2014-08-19 22:55 ` [PATCH 2/4] powerpc: Ensure global functions include their prototype Anton Blanchard
2014-08-19 22:55 ` [PATCH 3/4] powerpc: Remove stale function prototypes Anton Blanchard
2014-08-19 22:55 ` [PATCH 4/4] powerpc: Move htab_remove_mapping function prototype into header file Anton Blanchard
2014-08-22 15:29 ` Stephen Rothwell
2014-09-11 21:55 ` Anton Blanchard [this message]
2014-09-16 12:56 ` [PATCH 1/4] powerpc: Make a bunch of things static Nathan Fontenot
2014-09-17 3:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912075514.06703989@kryten \
--to=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).