From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 622CE1A012E for ; Sun, 14 Sep 2014 11:19:35 +1000 (EST) Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 14 Sep 2014 11:19:34 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 948953578047 for ; Sun, 14 Sep 2014 11:19:31 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8E1KxrD15991014 for ; Sun, 14 Sep 2014 11:20:59 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8E1JUYN009287 for ; Sun, 14 Sep 2014 11:19:31 +1000 Date: Sun, 14 Sep 2014 11:19:29 +1000 From: Gavin Shan To: Wei Yang Subject: Re: [PATCH V2] powerpc/eeh: Fix kernel crash when passing through VF Message-ID: <20140914011929.GA4475@shangw> Reply-To: Gavin Shan References: <1410406921-8557-1-git-send-email-weiyang@linux.vnet.ibm.com> <1410494123.17540.2.camel@concordia> <20140912050518.GA17933@shangw> <20140912093525.GA6916@richard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20140912093525.GA6916@richard> Cc: linuxppc-dev@lists.ozlabs.org, Gavin Shan List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Sep 12, 2014 at 05:35:25PM +0800, Wei Yang wrote: >On Fri, Sep 12, 2014 at 03:05:18PM +1000, Gavin Shan wrote: >>On Fri, Sep 12, 2014 at 01:55:23PM +1000, Michael Ellerman wrote: >>>On Thu, 2014-09-11 at 11:42 +0800, Wei Yang wrote: >>>> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c >>>> index 4a45ba8..403445e 100644 >>>> --- a/arch/powerpc/kernel/eeh.c >>>> +++ b/arch/powerpc/kernel/eeh.c >>>> @@ -625,7 +625,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function) >>>> int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state state) >>>> { >>>> struct eeh_dev *edev = pci_dev_to_eeh_dev(dev); >>>> - struct eeh_pe *pe = edev->pe; >>>> + struct eeh_pe *pe = edev ? edev->pe : NULL; >>>> >>>> if (!pe) { >>>> pr_err("%s: No PE found on PCI device %s\n", >>> >>> >>>We seem to do this or something similar in a few places. Is it worth having a >>>pci_dev_to_eeh_pe() inline? >>> >> >>Yes, maybe we just need a eeh_dev_to_pe() because converting >>pci_dev to eeh_dev is already coverred by pci_dev_to_eeh_dev(). >> >>With eeh_dev_to_pe(), it looks like this: >> >>struct pci_dev *pdev; >>struct eeh_dev *edev = pci_dev_to_eeh_dev(pdev); >>struct eeh_pe *pe = eeh_dev_to_pe(edev); >> >>Or another case: >> >>struct device_node *dn; >>struct eeh_dev *edev = of_node_to_eeh_dev(dn); >>struct eeh_pe *pe = eeh_dev_to_pe(edev); > >With these helper, it would be more consolidate to jump between those data. > >Gavin, > >You would add these helpers? Or would like me to add them? > It would be Richard to help on this :-) Thanks, Gavin