From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.de,
linux-kernel@vger.kernel.org, timur@tabi.org, perex@perex.cz,
Li.Xiubo@freescale.com, linuxppc-dev@lists.ozlabs.org,
shawn.guo@freescale.com
Subject: Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver
Date: Tue, 16 Sep 2014 11:32:31 -0700 [thread overview]
Message-ID: <20140916183231.GW7960@sirena.org.uk> (raw)
In-Reply-To: <20140916180028.GA6784@Asurada>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote:
> So I think, if it's a shared clock, we should not define it as a
> rate-changeable one in the SoC level, as we might still have some
> SoCs provide a dedicated clock to S/PDIF so as to get the maximum
> range of clock support for users.
> @Shawn
> Sorry to involve you in this topic. I'm not so sure if we can do
> this in the clock driver so that the clock rate would be fixed
> even if the driver is trying to change it. If we can, I think we
> may use a better solution here instead.
I tend to agree here. My first thought here is that we should have
support in the clock API for constraining clocks in the clock API so we
can still set the clock where there's a possibility to do that. Not
trivail to implement though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-09-16 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 11:46 [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver Shengjiu Wang
2014-09-16 18:19 ` Nicolin Chen
2014-09-16 18:32 ` Mark Brown [this message]
2014-09-17 1:32 ` Shawn Guo
2014-09-17 2:24 ` Nicolin Chen
2014-09-17 2:31 ` Shawn Guo
2014-09-17 2:50 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916183231.GW7960@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shawn.guo@freescale.com \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).