From: Michael Ellerman <mpe@ellerman.id.au>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: mikey@neuling.org, qiudayu@linux.vnet.ibm.com,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [2/4] powerpc/eeh: Introduce eeh_ops::err_inject
Date: Wed, 24 Sep 2014 12:23:17 +1000 (EST) [thread overview]
Message-ID: <20140924022317.C98A61400B5@ozlabs.org> (raw)
In-Reply-To: <1409039779-392-3-git-send-email-gwshan@linux.vnet.ibm.com>
On Tue, 2014-26-08 at 07:56:17 UTC, Gavin Shan wrote:
> From: Mike Qiu <qiudayu@linux.vnet.ibm.com>
>
> +
> + /* Firmware supports error injection ? */
> + ret = opal_check_token(OPAL_PCI_ERR_INJCT);
> + if (ret != OPAL_TOKEN_PRESENT) {
> + pr_warn("%s: Firmware not support error injection (%lld)\n",
> + __func__, ret);
This doesn't build, we dropped OPAL_TOKEN_PRESENT.
I've replaced it with:
if (!opal_check_token(OPAL_PCI_ERR_INJCT)) {
pr_warn("%s: Firmware doesn't support error injection (%lld)\n",
__func__, ret);
cheers
next prev parent reply other threads:[~2014-09-24 2:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:56 [PATCH 0/4] powerpc/eeh: More precisely error injection Gavin Shan
2014-08-26 7:56 ` [PATCH 1/4] powerpc/powernv: Sync header with firmware Gavin Shan
2014-09-25 4:27 ` [1/4] " Michael Ellerman
2014-09-25 4:56 ` Gavin Shan
2014-09-26 6:48 ` Gavin Shan
2014-10-03 5:30 ` Stewart Smith
2014-10-03 6:40 ` Gavin Shan
2014-08-26 7:56 ` [PATCH 2/4] powerpc/eeh: Introduce eeh_ops::err_inject Gavin Shan
2014-09-24 2:23 ` Michael Ellerman [this message]
2014-08-26 7:56 ` [PATCH 3/4] powerpc/powernv: Add error injection debugfs entry Gavin Shan
2014-08-26 7:56 ` [PATCH 4/4] powerpc/powernv: Clear PAPR error injection registers Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924022317.C98A61400B5@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).