From: Segher Boessenkool <segher@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
Steven Rostedt <rostedt@goodmis.org>,
Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return
Date: Fri, 26 Sep 2014 19:22:28 -0500 [thread overview]
Message-ID: <20140927002228.GC18404@gate.crashing.org> (raw)
In-Reply-To: <20140924123307.7649bec8@kryten>
On Wed, Sep 24, 2014 at 12:33:07PM +1000, Anton Blanchard wrote:
> We are scratching our heads trying to remember details of the issue
> right now. In retrospect we should have linked the gcc bugzilla or
> gcc commit details in the kernel commit message :)
There have been many GCC bugs in this area.
30282 (for 32-bit)
44199 (for 64-bit)
52828 (for everything, and this one should finally handle things for good)
Also a bunch of duplicates, and I'm sure I've missed some more.
The original issue as far as I remember: when using a frame pointer, GCC
would sometimes schedule the epilogue to do the stack adjust before
restoring all regs from the stack. Then an interrupt comes in, those
saved regs are clobbered, kaboom. We cannot disable the frame pointer
because -pg forces it (although PowerPC does not need it). The
-mno-sched-epilog flag is a workaround: the epilogue (and prologue) will
not be reordered by instruction scheduling. Slow code is better than
blowing up fast ;-)
Segher
next prev parent reply other threads:[~2014-09-27 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 7:07 [PATCH 1/3] powerpc: Remove -mno-sched-epilog workaround Anton Blanchard
2014-09-17 7:07 ` [PATCH 2/3] powerpc/ftrace: Remove mod_return_to_handler Anton Blanchard
2014-09-23 23:20 ` Steven Rostedt
2014-09-17 7:07 ` [PATCH 3/3] powerpc/ftrace: simplify prepare_ftrace_return Anton Blanchard
2014-09-23 23:46 ` Steven Rostedt
2014-09-23 23:54 ` Steven Rostedt
2014-09-24 2:22 ` Anton Blanchard
2014-09-24 2:24 ` Benjamin Herrenschmidt
2014-09-24 2:33 ` Anton Blanchard
2014-09-24 2:44 ` Steven Rostedt
2014-09-27 0:22 ` Segher Boessenkool [this message]
2014-10-28 4:55 ` Anton Blanchard
2014-09-23 23:11 ` [PATCH 1/3] powerpc: Remove -mno-sched-epilog workaround Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140927002228.GC18404@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=amodra@gmail.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).