From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: ak@linux.intel.com, Michael Ellerman <michaele@au1.ibm.com>,
peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, eranian@google.com,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
dev@codyps.com, Jiri Olsa <jolsa@redhat.com>,
Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: [v2,2/4] Simplify catalog_read()
Date: Tue, 30 Sep 2014 17:59:05 -0700 [thread overview]
Message-ID: <20141001005905.GB4441@us.ibm.com> (raw)
In-Reply-To: <20141001003213.A8F78140273@ozlabs.org>
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
| >
| > page_offset = offset / 4096;
| > page_count = count / 4096;
|
| I don't see where page_count is used.
Yes, I will remove it.
|
| > + offset_in_page = count % 4096;
|
| Shouldn't offset_in_page be based on offset ?
Yes. I will fix that.
Thanks,
Sukadev
next prev parent reply other threads:[~2014-10-01 0:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 19:24 [PATCH v2 0/4] powerpc/perf: Miscellaneous fixes Sukadev Bhattiprolu
2014-09-24 19:24 ` [PATCH v2 1/4] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations Sukadev Bhattiprolu
2014-10-01 1:23 ` [v2, " Michael Ellerman
2014-09-24 19:24 ` [PATCH v2 2/4] Simplify catalog_read() Sukadev Bhattiprolu
2014-10-01 0:32 ` [v2,2/4] " Michael Ellerman
2014-10-01 0:59 ` Sukadev Bhattiprolu [this message]
2014-09-24 19:24 ` [PATCH v2 3/4] perf Documentation: sysfs events/ interfaces Sukadev Bhattiprolu
2014-09-24 19:24 ` [PATCH v2 4/4] perf Documentation: remove duplicated docs for powerpc cpu specific events Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001005905.GB4441@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=dev@codyps.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michaele@au1.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).