From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/6] powerpc/eeh: Refactor config accessors
Date: Wed, 1 Oct 2014 17:12:04 +1000 [thread overview]
Message-ID: <20141001071204.GA28956@shangw> (raw)
In-Reply-To: <1412147274-28770-1-git-send-email-gwshan@linux.vnet.ibm.com>
On Wed, Oct 01, 2014 at 05:07:48PM +1000, Gavin Shan wrote:
>When EEH errors are detected on some particular PCI adapters, one of
>which is shown as follows, the PCI config space of thoese PCI adapters
>(PE) should be blocked. Otherwise, we will run into fenced PHB when
>collecting EEH logs (part of recovery). The patchset fixes this issue.
>Also, EEH_PE_RESET is replaced with EEH_PE_CFG_BLOCKED to indicate its
>usage. It's bad idea to allow PCI config access even EEH_PE_CFG_BLOCKED
>flag is set for the corresponding PE because it potentially triggers
>recursive EEH error. The patchset also blocks config request from EEH
>backend if necessary.
>
Missed to attach the logs from "lspci" to point the adapters we have
problems with:
# lspci -s 0003:09:00.0
0003:09:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5719 \
Gigabit Ethernet PCIe (rev 01)
# lspci -n -s 0003:09:00.0
0003:09:00.0 0200: 14e4:1657 (rev 01)
Thanks,
Gavin
>Gavin Shan (6):
> powerpc/eeh: Fix condition for isolated state
> powerpc/eeh: Rename flag EEH_PE_RESET to EEH_PE_CFG_BLOCKED
> powerpc/powernv: Drop config requests in EEH accessors
> powerpc/pseries: Drop config requests in EEH accessors
> powerpc/eeh: Block PCI config access upon frozen PE
> powerpc/eeh: Don't collect logs on PE with blocked config space
>
> arch/powerpc/include/asm/eeh.h | 3 +-
> arch/powerpc/kernel/eeh.c | 19 +++++++---
> arch/powerpc/kernel/eeh_driver.c | 12 +++---
> arch/powerpc/kernel/eeh_pe.c | 10 ++++-
> arch/powerpc/kernel/rtas_pci.c | 30 ++++++---------
> arch/powerpc/platforms/powernv/eeh-ioda.c | 2 +-
> arch/powerpc/platforms/powernv/eeh-powernv.c | 56 +++++++++++++++++++++++++++-
> arch/powerpc/platforms/powernv/pci.c | 2 +-
> 8 files changed, 97 insertions(+), 37 deletions(-)
>
>--
>1.8.3.2
>
prev parent reply other threads:[~2014-10-01 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 7:07 [PATCH 0/6] powerpc/eeh: Refactor config accessors Gavin Shan
2014-10-01 7:07 ` [PATCH 1/6] powerpc/eeh: Fix condition for isolated state Gavin Shan
2014-10-01 7:07 ` [PATCH 2/6] powerpc/eeh: Rename flag EEH_PE_RESET to EEH_PE_CFG_BLOCKED Gavin Shan
2014-10-01 7:07 ` [PATCH 3/6] powerpc/powernv: Drop config requests in EEH accessors Gavin Shan
2014-10-01 7:07 ` [PATCH 4/6] powerpc/pseries: " Gavin Shan
2014-10-01 7:07 ` [PATCH 5/6] powerpc/eeh: Block PCI config access upon frozen PE Gavin Shan
2014-10-01 7:07 ` [PATCH 6/6] powerpc/eeh: Don't collect logs on PE with blocked config space Gavin Shan
2014-10-01 7:12 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001071204.GA28956@shangw \
--to=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).