From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f178.google.com (mail-ie0-f178.google.com [209.85.223.178]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 57BE21A02FC for ; Tue, 7 Oct 2014 18:52:48 +1100 (EST) Received: by mail-ie0-f178.google.com with SMTP id rl12so4910874iec.9 for ; Tue, 07 Oct 2014 00:52:46 -0700 (PDT) Date: Tue, 7 Oct 2014 08:52:38 +0100 From: Lee Jones To: Guenter Roeck Subject: Re: [PATCH 18/44] mfd: twl4030-power: Register with kernel poweroff handler Message-ID: <20141007075238.GA25331@lee--X1> References: <1412659726-29957-1-git-send-email-linux@roeck-us.net> <1412659726-29957-19-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1412659726-29957-19-git-send-email-linux@roeck-us.net> Cc: linux-m32r-ja@ml.linux-m32r.org, linux-mips@linux-mips.org, linux-efi@vger.kernel.org, linux-ia64@vger.kernel.org, linux-xtensa@linux-xtensa.org, devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, lguest@lists.ozlabs.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, xen-devel@lists.xenproject.org, devicetree@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, linux-pm@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, linux-m68k@lists.linux-m68k.org, linux-am33-list@redhat.com, linux-tegra@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Samuel Ortiz , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 06 Oct 2014, Guenter Roeck wrote: > Register with kernel poweroff handler instead of setting pm_power_off > directly. Register with a low priority value of 64 to reflect that > the original code only sets pm_power_off if it was not already set. > > Make twl4030_power_off static as it is only called from the twl4030-power > driver. > > Cc: Samuel Ortiz > Cc: Lee Jones > Signed-off-by: Guenter Roeck > --- > drivers/mfd/twl4030-power.c | 25 +++++++++++++++++++++---- > include/linux/i2c/twl.h | 1 - > 2 files changed, 21 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > index 4d3ff37..bd6b830 100644 > --- a/drivers/mfd/twl4030-power.c > +++ b/drivers/mfd/twl4030-power.c > @@ -25,9 +25,10 @@ > */ > > #include > -#include > +#include > #include > #include > +#include > #include > #include > > @@ -611,7 +612,8 @@ twl4030_power_configure_resources(const struct twl4030_power_data *pdata) > * After a successful execution, TWL shuts down the power to the SoC > * and all peripherals connected to it. > */ > -void twl4030_power_off(void) > +static int twl4030_power_off(struct notifier_block *this, unsigned long unused1, > + void *unused2) > { > int err; > > @@ -619,8 +621,15 @@ void twl4030_power_off(void) > TWL4030_PM_MASTER_P1_SW_EVENTS); > if (err) > pr_err("TWL4030 Unable to power off\n"); > + > + return NOTIFY_DONE; > } > > +static struct notifier_block twl4030_poweroff_nb = { > + .notifier_call = twl4030_power_off, > + .priority = 64, 64 out of what? How is this calculated? Wouldn't it be better to define these? > +}; > + > static bool twl4030_power_use_poweroff(const struct twl4030_power_data *pdata, > struct device_node *node) > { > @@ -836,7 +845,7 @@ static int twl4030_power_probe(struct platform_device *pdev) > } > > /* Board has to be wired properly to use this feature */ > - if (twl4030_power_use_poweroff(pdata, node) && !pm_power_off) { > + if (twl4030_power_use_poweroff(pdata, node)) { > /* Default for SEQ_OFFSYNC is set, lets ensure this */ > err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val, > TWL4030_PM_MASTER_CFG_P123_TRANSITION); > @@ -853,7 +862,13 @@ static int twl4030_power_probe(struct platform_device *pdev) > } > } > > - pm_power_off = twl4030_power_off; > + err = register_poweroff_handler(&twl4030_poweroff_nb); > + if (err) { > + dev_err(&pdev->dev, > + "Failed to register poweroff handler\n"); If this is not fatal, you should issue a dev_warn() instead. > + /* Not a fatal error */ > + err = 0; How about using your own variable for this? Then you don't have to worry about resetting it. > + } > } > > relock: > @@ -869,6 +884,8 @@ relock: > > static int twl4030_power_remove(struct platform_device *pdev) > { > + unregister_poweroff_handler(&twl4030_poweroff_nb); Perhaps a naive question, but is there any way you can do this using devres (devm_* managed resources)? > return 0; > } > > diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h > index 8cfb50f..f8544f1 100644 > --- a/include/linux/i2c/twl.h > +++ b/include/linux/i2c/twl.h > @@ -680,7 +680,6 @@ struct twl4030_power_data { > }; > > extern int twl4030_remove_script(u8 flags); > -extern void twl4030_power_off(void); > > struct twl4030_codec_data { > unsigned int digimic_delay; /* in ms */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog