From: Steve Capper <steve.capper@linaro.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory
Date: Tue, 28 Oct 2014 10:44:52 +0000 [thread overview]
Message-ID: <20141028104451.GB4187@linaro.org> (raw)
In-Reply-To: <20141027183241.a5339085.akpm@linux-foundation.org>
On Mon, Oct 27, 2014 at 06:32:41PM -0700, Andrew Morton wrote:
> On Tue, 28 Oct 2014 12:20:29 +1100 Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> > On Mon, 2014-10-27 at 16:06 -0700, Andrew Morton wrote:
> > > On Sat, 25 Oct 2014 16:14:19 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> > >
> > > > Update generic gup implementation with powerpc specific details.
> > > > On powerpc at pmd level we can have hugepte, normal pmd pointer
> > > > or a pointer to the hugepage directory.
> > >
> > > I grabbed these. It would be better if they were merged into the powerpc
> > > tree where they'll get more testing than in linux-next alone.
> >
> > Fine by me. Can I get an ack from you and/or someone else on CC?
> >
>
> Only arm and arm64 use this code. Steve, could you please look it over
> and check that arm is still happy?
Hi Andrew,
I've tested it and posted some comments on it.
If the arch/arm and arch/arm64 changes are removed and a comment about
an assumption made by the new gup_huge_pte code is added then I'm happy.
Cheers,
--
Steve
next prev parent reply other threads:[~2014-10-28 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 10:44 [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory Aneesh Kumar K.V
2014-10-25 10:44 ` [PATCH V3 2/2] arch/powerpc: Switch to generic RCU get_user_pages_fast Aneesh Kumar K.V
2014-10-27 23:06 ` [PATCH V3 1/2] mm: Update generic gup implementation to handle hugepage directory Andrew Morton
2014-10-28 1:20 ` Michael Ellerman
2014-10-28 1:32 ` Andrew Morton
2014-10-28 10:44 ` Steve Capper [this message]
2014-10-29 4:46 ` Michael Ellerman
2014-10-28 10:41 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028104451.GB4187@linaro.org \
--to=steve.capper@linaro.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).