From: David Miller <davem@davemloft.net>
To: aneesh.kumar@linux.vnet.ibm.com
Cc: aarcange@redhat.com, linux-arch@vger.kernel.org,
steve.capper@linaro.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory
Date: Sat, 01 Nov 2014 14:05:54 -0400 (EDT) [thread overview]
Message-ID: <20141101.140554.427928361730485371.davem@davemloft.net> (raw)
In-Reply-To: <1414570785-18966-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Date: Wed, 29 Oct 2014 13:49:44 +0530
> +/*
> + * Some architectures requires a hugepage directory format that is
> + * required to support multiple hugepage sizes. For example
> + * a4fe3ce7699bfe1bd88f816b55d42d8fe1dac655 introduced the same
> + * on powerpc. This allows for a more flexible hugepage pagetable
> + * layout.
> + */
Please don't put commit IDs into the actual code.
If that commit gets backported to -stable or another tree, then this
comment will send someone on a wild goose chase.
next prev parent reply other threads:[~2014-11-01 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:19 [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory Aneesh Kumar K.V
2014-10-29 8:19 ` [PATCH V4 2/2] arch/powerpc: Switch to generic RCU get_user_pages_fast Aneesh Kumar K.V
2014-10-29 9:25 ` [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory Steve Capper
2014-11-01 18:05 ` David Miller [this message]
2014-11-01 19:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101.140554.427928361730485371.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=steve.capper@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).