From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CB6D41A0808 for ; Tue, 18 Nov 2014 15:33:14 +1100 (AEDT) In-Reply-To: <1416192750.3375.7.camel@TP420> To: Li Zhong , PowerPC email list From: Michael Ellerman Subject: Re: [powerpc] init nvram_pstore_info's buf_lock Message-Id: <20141118043314.4517C14011D@ozlabs.org> Date: Tue, 18 Nov 2014 15:33:14 +1100 (AEDT) Cc: Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2014-17-11 at 02:52:30 UTC, Li Zhong wrote: > It seems nvram_pstore_info's buf_lock is not initialized before > registering, which causes some strange behavior when trying to obtain > the lock during kdump process. What kind of strange behaviour? Does it still work and just print a warning? It's static, so I'd expect it to be unlocked by default. cheers