From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: drop useless warning in eeh_init()
Date: Wed, 26 Nov 2014 09:28:47 +1100 [thread overview]
Message-ID: <20141125222846.GA7662@shangw> (raw)
In-Reply-To: <20141125161006.1995.31789.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
>This is what we get in dmesg when booting a pseries guest and
>the hypervisor doesn't provide EEH support.
>
>[ 0.166655] EEH functionality not supported
>[ 0.166778] eeh_init: Failed to call platform init function (-22)
>
>Since both powernv_eeh_init() and pseries_eeh_init() already complain when
>hitting an error, it is not needed to print more (especially such an
>uninformative message).
>
>Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Thanks,
Gavin
>---
> arch/powerpc/kernel/eeh.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
>index 2248a19..7d62018 100644
>--- a/arch/powerpc/kernel/eeh.c
>+++ b/arch/powerpc/kernel/eeh.c
>@@ -920,11 +920,8 @@ int eeh_init(void)
> pr_warn("%s: Platform EEH operation not found\n",
> __func__);
> return -EEXIST;
>- } else if ((ret = eeh_ops->init())) {
>- pr_warn("%s: Failed to call platform init function (%d)\n",
>- __func__, ret);
>+ } else if ((ret = eeh_ops->init()))
> return ret;
>- }
>
> /* Initialize EEH event */
> ret = eeh_event_init();
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2014-11-25 22:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 16:10 [PATCH] powerpc: drop useless warning in eeh_init() Greg Kurz
2014-11-25 22:28 ` Gavin Shan [this message]
2014-12-03 14:20 ` Greg Kurz
2014-12-03 22:14 ` Gavin Shan
2014-12-04 0:32 ` Michael Ellerman
2014-12-04 8:09 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125222846.GA7662@shangw \
--to=gwshan@linux.vnet.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).