From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Jiada Wang <jiada_wang@mentor.com>,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
timur@tabi.org, nicoleotsuka@gmail.com, tiwai@suse.de,
Li.Xiubo@freescale.com, Markus Pargmann <mpa@pengutronix.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping()
Date: Mon, 1 Dec 2014 19:24:22 +0000 [thread overview]
Message-ID: <20141201192422.GL7712@sirena.org.uk> (raw)
In-Reply-To: <547C9C34.9080602@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Mon, Dec 01, 2014 at 05:49:56PM +0100, Lars-Peter Clausen wrote:
> On 12/01/2014 07:50 AM, Markus Pargmann wrote:
> >devm_request_irq() is used by other drivers too, this should not be a
> >problem. Looking at the code it seems that irq_dispose_mapping may not
> >be necessary with devm_request_irq(). So I think it would be better to
> >remove irq_dispose_mapping() instead.
> The driver creates the mapping by calling irq_of_parse_and_map(), so it also
> has to dispose the mapping. But the easy way out is to simply use
> platform_get_irq() instead of irq_of_parse_map(). In this case the mapping
> is not managed by the device but by the of core, so the device has not to
> dispose the mapping.
It also has the advantage of not being DT specific so providing some
chance that future firmware interfaces can be supported without driver
modification.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-12-01 19:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 2:50 [PATCH] ASoC: fsl_ssi: free irq before irq_dispose_mapping() Jiada Wang
2014-12-01 6:50 ` Markus Pargmann
2014-12-01 16:49 ` [alsa-devel] " Lars-Peter Clausen
2014-12-01 16:51 ` Timur Tabi
2014-12-01 16:59 ` Lars-Peter Clausen
2014-12-01 18:48 ` Timur Tabi
2014-12-01 19:39 ` Lars-Peter Clausen
2014-12-01 19:41 ` Mark Brown
2014-12-01 19:56 ` Arnd Bergmann
2014-12-01 19:59 ` Timur Tabi
2014-12-01 20:01 ` Arnd Bergmann
2014-12-01 20:11 ` Timur Tabi
2014-12-01 20:30 ` Lars-Peter Clausen
2014-12-01 20:40 ` Fabio Estevam
2014-12-01 20:42 ` Timur Tabi
2014-12-01 21:03 ` Fabio Estevam
2014-12-01 20:16 ` Mark Brown
2014-12-01 19:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201192422.GL7712@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=jiada_wang@mentor.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpa@pengutronix.de \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).