* [PATCH] powerpc: drop useless warning in eeh_init()
@ 2014-11-25 16:10 Greg Kurz
2014-11-25 22:28 ` Gavin Shan
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kurz @ 2014-11-25 16:10 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev
This is what we get in dmesg when booting a pseries guest and
the hypervisor doesn't provide EEH support.
[ 0.166655] EEH functionality not supported
[ 0.166778] eeh_init: Failed to call platform init function (-22)
Since both powernv_eeh_init() and pseries_eeh_init() already complain when
hitting an error, it is not needed to print more (especially such an
uninformative message).
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
arch/powerpc/kernel/eeh.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index 2248a19..7d62018 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -920,11 +920,8 @@ int eeh_init(void)
pr_warn("%s: Platform EEH operation not found\n",
__func__);
return -EEXIST;
- } else if ((ret = eeh_ops->init())) {
- pr_warn("%s: Failed to call platform init function (%d)\n",
- __func__, ret);
+ } else if ((ret = eeh_ops->init()))
return ret;
- }
/* Initialize EEH event */
ret = eeh_event_init();
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc: drop useless warning in eeh_init()
2014-11-25 16:10 [PATCH] powerpc: drop useless warning in eeh_init() Greg Kurz
@ 2014-11-25 22:28 ` Gavin Shan
2014-12-03 14:20 ` Greg Kurz
0 siblings, 1 reply; 6+ messages in thread
From: Gavin Shan @ 2014-11-25 22:28 UTC (permalink / raw)
To: Greg Kurz; +Cc: linuxppc-dev
On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
>This is what we get in dmesg when booting a pseries guest and
>the hypervisor doesn't provide EEH support.
>
>[ 0.166655] EEH functionality not supported
>[ 0.166778] eeh_init: Failed to call platform init function (-22)
>
>Since both powernv_eeh_init() and pseries_eeh_init() already complain when
>hitting an error, it is not needed to print more (especially such an
>uninformative message).
>
>Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Thanks,
Gavin
>---
> arch/powerpc/kernel/eeh.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
>index 2248a19..7d62018 100644
>--- a/arch/powerpc/kernel/eeh.c
>+++ b/arch/powerpc/kernel/eeh.c
>@@ -920,11 +920,8 @@ int eeh_init(void)
> pr_warn("%s: Platform EEH operation not found\n",
> __func__);
> return -EEXIST;
>- } else if ((ret = eeh_ops->init())) {
>- pr_warn("%s: Failed to call platform init function (%d)\n",
>- __func__, ret);
>+ } else if ((ret = eeh_ops->init()))
> return ret;
>- }
>
> /* Initialize EEH event */
> ret = eeh_event_init();
>
>_______________________________________________
>Linuxppc-dev mailing list
>Linuxppc-dev@lists.ozlabs.org
>https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc: drop useless warning in eeh_init()
2014-11-25 22:28 ` Gavin Shan
@ 2014-12-03 14:20 ` Greg Kurz
2014-12-03 22:14 ` Gavin Shan
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kurz @ 2014-12-03 14:20 UTC (permalink / raw)
To: Gavin Shan; +Cc: linuxppc-dev
On Wed, 26 Nov 2014 09:28:47 +1100
Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
> >This is what we get in dmesg when booting a pseries guest and
> >the hypervisor doesn't provide EEH support.
> >
> >[ 0.166655] EEH functionality not supported
> >[ 0.166778] eeh_init: Failed to call platform init function (-22)
> >
> >Since both powernv_eeh_init() and pseries_eeh_init() already complain when
> >hitting an error, it is not needed to print more (especially such an
> >uninformative message).
> >
> >Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>
> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>
> Thanks,
> Gavin
>
Ping ?
> >---
> > arch/powerpc/kernel/eeh.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> >diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> >index 2248a19..7d62018 100644
> >--- a/arch/powerpc/kernel/eeh.c
> >+++ b/arch/powerpc/kernel/eeh.c
> >@@ -920,11 +920,8 @@ int eeh_init(void)
> > pr_warn("%s: Platform EEH operation not found\n",
> > __func__);
> > return -EEXIST;
> >- } else if ((ret = eeh_ops->init())) {
> >- pr_warn("%s: Failed to call platform init function (%d)\n",
> >- __func__, ret);
> >+ } else if ((ret = eeh_ops->init()))
> > return ret;
> >- }
> >
> > /* Initialize EEH event */
> > ret = eeh_event_init();
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >Linuxppc-dev@lists.ozlabs.org
> >https://lists.ozlabs.org/listinfo/linuxppc-dev
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc: drop useless warning in eeh_init()
2014-12-03 14:20 ` Greg Kurz
@ 2014-12-03 22:14 ` Gavin Shan
2014-12-04 0:32 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Gavin Shan @ 2014-12-03 22:14 UTC (permalink / raw)
To: Greg Kurz; +Cc: linuxppc-dev, Gavin Shan
On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote:
>On Wed, 26 Nov 2014 09:28:47 +1100
>Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
>> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
>> >This is what we get in dmesg when booting a pseries guest and
>> >the hypervisor doesn't provide EEH support.
>> >
>> >[ 0.166655] EEH functionality not supported
>> >[ 0.166778] eeh_init: Failed to call platform init function (-22)
>> >
>> >Since both powernv_eeh_init() and pseries_eeh_init() already complain when
>> >hitting an error, it is not needed to print more (especially such an
>> >uninformative message).
>> >
>> >Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
>>
>> Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>>
>> Thanks,
>> Gavin
>>
>
>Ping ?
>
It's already in Michael's git tree.
shangw@shangw:~/sandbox/linux.ppc$ git remote -v
origin git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux.git (fetch)
origin git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux.git (push)
shangw@shangw:~/sandbox/linux.ppc$ git branch
master
* next
shangw@shangw:~/sandbox/linux.ppc$ git log --author="Greg Kurz" --oneline
1 221195f powerpc: Drop useless warning in eeh_init()
Thanks,
Gavin
>> >---
>> > arch/powerpc/kernel/eeh.c | 5 +----
>> > 1 file changed, 1 insertion(+), 4 deletions(-)
>> >
>> >diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
>> >index 2248a19..7d62018 100644
>> >--- a/arch/powerpc/kernel/eeh.c
>> >+++ b/arch/powerpc/kernel/eeh.c
>> >@@ -920,11 +920,8 @@ int eeh_init(void)
>> > pr_warn("%s: Platform EEH operation not found\n",
>> > __func__);
>> > return -EEXIST;
>> >- } else if ((ret = eeh_ops->init())) {
>> >- pr_warn("%s: Failed to call platform init function (%d)\n",
>> >- __func__, ret);
>> >+ } else if ((ret = eeh_ops->init()))
>> > return ret;
>> >- }
>> >
>> > /* Initialize EEH event */
>> > ret = eeh_event_init();
>> >
>> >_______________________________________________
>> >Linuxppc-dev mailing list
>> >Linuxppc-dev@lists.ozlabs.org
>> >https://lists.ozlabs.org/listinfo/linuxppc-dev
>>
>> _______________________________________________
>> Linuxppc-dev mailing list
>> Linuxppc-dev@lists.ozlabs.org
>> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc: drop useless warning in eeh_init()
2014-12-03 22:14 ` Gavin Shan
@ 2014-12-04 0:32 ` Michael Ellerman
2014-12-04 8:09 ` Greg Kurz
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2014-12-04 0:32 UTC (permalink / raw)
To: Gavin Shan; +Cc: linuxppc-dev, Greg Kurz
On Thu, 2014-12-04 at 09:14 +1100, Gavin Shan wrote:
> On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote:
> >On Wed, 26 Nov 2014 09:28:47 +1100
> >Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> >> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
> >> >This is what we get in dmesg when booting a pseries guest and
> >> >the hypervisor doesn't provide EEH support.
> >
> >Ping ?
>
> It's already in Michael's git tree.
Indeed.
It's also marked as "Under Review" in patchwork, which basically means I've
seen it and it's on its way into my tree unless you hear otherwise.
http://patchwork.ozlabs.org/patch/414753/
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc: drop useless warning in eeh_init()
2014-12-04 0:32 ` Michael Ellerman
@ 2014-12-04 8:09 ` Greg Kurz
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kurz @ 2014-12-04 8:09 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, Gavin Shan
On Thu, 04 Dec 2014 11:32:45 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Thu, 2014-12-04 at 09:14 +1100, Gavin Shan wrote:
> > On Wed, Dec 03, 2014 at 03:20:46PM +0100, Greg Kurz wrote:
> > >On Wed, 26 Nov 2014 09:28:47 +1100
> > >Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> > >> On Tue, Nov 25, 2014 at 05:10:06PM +0100, Greg Kurz wrote:
> > >> >This is what we get in dmesg when booting a pseries guest and
> > >> >the hypervisor doesn't provide EEH support.
> > >
> > >Ping ?
> >
> > It's already in Michael's git tree.
>
> Indeed.
>
> It's also marked as "Under Review" in patchwork, which basically means I've
> seen it and it's on its way into my tree unless you hear otherwise.
>
> http://patchwork.ozlabs.org/patch/414753/
>
> cheers
>
>
Sorry for the noise, I'll check next time... :\
--
G
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-12-04 8:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 16:10 [PATCH] powerpc: drop useless warning in eeh_init() Greg Kurz
2014-11-25 22:28 ` Gavin Shan
2014-12-03 14:20 ` Greg Kurz
2014-12-03 22:14 ` Gavin Shan
2014-12-04 0:32 ` Michael Ellerman
2014-12-04 8:09 ` Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).