linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/pci: remove pci device on a bus in reverse order
Date: Thu, 4 Dec 2014 11:26:04 +0800	[thread overview]
Message-ID: <20141204032604.GA8943@richard> (raw)
In-Reply-To: <1417662272-8444-1-git-send-email-weiyang@linux.vnet.ibm.com>

Please ignore this one, I create an old version of the patch.

The new one is sent.

On Thu, Dec 04, 2014 at 11:04:32AM +0800, Wei Yang wrote:
>As in commit ac205b7b (PCI: make sriov work with hotplug remove) indicates,
>when removing pci devices on a bus which has VFs, we need to remove them in
>the reverse order.
>
>This patch applies this patten on the hotplug remove patch on powerpc arch.
>
>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>---
> arch/powerpc/kernel/pci-hotplug.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/powerpc/kernel/pci-hotplug.c b/arch/powerpc/kernel/pci-hotplug.c
>index 5b78917..f0f00d9 100644
>--- a/arch/powerpc/kernel/pci-hotplug.c
>+++ b/arch/powerpc/kernel/pci-hotplug.c
>@@ -50,7 +50,7 @@ void pcibios_remove_pci_devices(struct pci_bus *bus)
>
> 	pr_debug("PCI: Removing devices on bus %04x:%02x\n",
> 		 pci_domain_nr(bus),  bus->number);
>-	list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) {
>+	list_for_each_entry_safe_reverse(dev, tmp, &bus->devices, bus_list) {
> 		pr_debug("   Removing %s...\n", pci_name(dev));
> 		pci_stop_and_remove_bus_device(dev);
> 	}
>-- 
>1.7.9.5

-- 
Richard Yang
Help you, Help me

      parent reply	other threads:[~2014-12-04  3:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  3:04 [PATCH] powerpc/pci: remove pci device on a bus in reverse order Wei Yang
2014-12-04  3:24 ` Wei Yang
2014-12-04  5:40   ` Michael Ellerman
2014-12-04  7:21     ` Wei Yang
2014-12-04 22:48       ` Gavin Shan
2014-12-05  1:40         ` Wei Yang
2014-12-04  3:26 ` Wei Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141204032604.GA8943@richard \
    --to=weiyang@linux.vnet.ibm.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).