From: Wei Yang <weiyang@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Wei Yang <weiyang@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org, gwshan@linux.vnet.ibm.com
Subject: Re: powerpc/pci: remove pci device on a bus in reverse order
Date: Thu, 4 Dec 2014 15:21:18 +0800 [thread overview]
Message-ID: <20141204072117.GA9978@richard> (raw)
In-Reply-To: <20141204054035.C3DAC1400E9@ozlabs.org>
On Thu, Dec 04, 2014 at 04:40:35PM +1100, Michael Ellerman wrote:
>On Thu, 2014-04-12 at 03:24:37 UTC, Wei Yang wrote:
>> As in commit ac205b7b (PCI: make sriov work with hotplug remove) indicates,
>> when removing pci devices on a bus which has VFs, we need to remove them in
>> the reverse order.
>>
>> This patch applies this pattern on the hotplug remove path on powerpc arch.
>
>So is this is a bug fix?
It hasn't trigger a bug yet. I found this issue during the code reading. When
VFs are enabled and try to remove a bus with VFs, it will face a problem. So I
port the change in commit ac205b7b here.
>
>Where/how have you tested this?
I have tested after change on Power8, the EEH hotplug path works fine for PFs
now. Will test this when EEH for VFs are ready.
Suggest me to keep it untill EEH for VFs are ready?
>
>cheers
--
Richard Yang
Help you, Help me
next prev parent reply other threads:[~2014-12-04 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 3:04 [PATCH] powerpc/pci: remove pci device on a bus in reverse order Wei Yang
2014-12-04 3:24 ` Wei Yang
2014-12-04 5:40 ` Michael Ellerman
2014-12-04 7:21 ` Wei Yang [this message]
2014-12-04 22:48 ` Gavin Shan
2014-12-05 1:40 ` Wei Yang
2014-12-04 3:26 ` [PATCH] " Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204072117.GA9978@richard \
--to=weiyang@linux.vnet.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).