From: Wolfram Sang <wsa@the-dreams.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter
Date: Thu, 4 Dec 2014 18:46:42 +0100 [thread overview]
Message-ID: <20141204174642.GA7944@katana> (raw)
In-Reply-To: <s5hiohrpd0w.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
> > +
> > + /* We assume Macs have consecutive I2C bus numbers starting at 0 */
> > + while (adap) {
> > + err = keywest_attach_adapter(adap);
> > + if (!err)
> > + break;
> > + i2c_put_adapter(adap);
> > + adap = i2c_get_adapter(++i);
> > + }
> > +
> > return 0;
>
> What if adap is NULL in the last while loop? Isn't it supposed to
> return an error?
True, we probably should have something like
return adap ? 0 : -ENODEV;
Thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-12-04 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 16:41 [RFC 0/2] get rid of remaining users of attach_adapter Wolfram Sang
2014-12-04 16:41 ` [RFC 1/2] macintosh: therm_windtunnel: drop using attach adapter Wolfram Sang
2014-12-04 16:41 ` [RFC 2/2] sound: ppc: keywest: " Wolfram Sang
2014-12-04 16:58 ` [alsa-devel] " Takashi Iwai
2014-12-04 17:46 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204174642.GA7944@katana \
--to=wsa@the-dreams.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).