From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 30FF81A0BD8 for ; Sat, 6 Dec 2014 02:34:47 +1100 (AEDT) Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Dec 2014 15:34:44 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 0D5E51B08061 for ; Fri, 5 Dec 2014 15:35:00 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sB5FYeUA58720446 for ; Fri, 5 Dec 2014 15:34:41 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sB5FYew9012430 for ; Fri, 5 Dec 2014 08:34:40 -0700 Date: Fri, 5 Dec 2014 16:34:38 +0100 From: Greg Kurz To: linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2 3/4] powerpc: drop smp_generic_cpu_bootable() Message-ID: <20141205163438.43e7b336@bahia.local> In-Reply-To: <20141205151455.11028.573.stgit@bahia.lab.toulouse-stg.fr.ibm.com> References: <20141205150405.11028.27445.stgit@bahia.lab.toulouse-stg.fr.ibm.com> <20141205151455.11028.573.stgit@bahia.lab.toulouse-stg.fr.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Subject should read "powerpc: drop useless code in smp_generic_cpu_bootable()" actually... On Fri, 05 Dec 2014 16:15:12 +0100 Greg Kurz wrote: > The following assertions are always true: > - threads_per_core > 0 > - cpu & (threads_per_core - 1) < threads_per_core > > It means smp_generic_cpu_bootable() always returns true. > > Signed-off-by: Greg Kurz > --- > arch/powerpc/kernel/smp.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 9577791..8d7f114 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -89,17 +89,6 @@ static void (*crash_ipi_function_ptr)(struct pt_regs *) = NULL; > */ > int smp_generic_cpu_bootable(unsigned int nr) > { > - /* Special case - we inhibit secondary thread startup > - * during boot if the user requests it. > - */ > - if (system_state == SYSTEM_BOOTING && cpu_has_feature(CPU_FTR_SMT)) { > - if (!threads_per_core && cpu_thread_in_core(nr) != 0) > - return 0; > - if (threads_per_core > - && cpu_thread_in_core(nr) >= threads_per_core) > - return 0; > - } > - > return 1; > } > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev