From: Wolfram Sang <wsa@the-dreams.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses
Date: Tue, 9 Dec 2014 09:54:35 +0100 [thread overview]
Message-ID: <20141209085435.GA1154@katana> (raw)
In-Reply-To: <1418075026.13358.4.camel@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
> > Oh, I thought we agreed that you take it via powerpc. I still think this
> > is the best solution.
>
> I threatened to do that :-) I don't remember you replying, did I miss
> it ?
It is here:
http://thread.gmane.org/gmane.linux.drivers.i2c/20762/focus=21099
> If you are ok with the driver and are happy for me to take it,
> please send an Ack.
"Happy" is not the correct word, but let's just go over with it. Maybe
like this:
Acked-by: Wolfram Sang <wsa@the-dreams.de> (I2C part, excluding the bindings)
> From a binding perspective, it's just a piece of additional info that
> the firmware provides for convenience.
I do understand the use case. I even agree it makes sense to have
something like this. It is just that I'd prefer a generic, widely
acknowledged solution, with consensus where it belongs and how it should
be named. Not a custom solution which, frankly, feels forced on me
by time pressure I have nothing to do with. So, not happy here, but also
not looking for drama. Let's move on...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-09 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 6:36 [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses Neelesh Gupta
2014-12-08 20:13 ` Benjamin Herrenschmidt
2014-12-08 20:55 ` Wolfram Sang
2014-12-08 21:43 ` Benjamin Herrenschmidt
2014-12-09 8:54 ` Wolfram Sang [this message]
2014-12-09 9:43 ` Benjamin Herrenschmidt
2014-12-09 9:45 ` [v3] " Michael Ellerman
2014-12-09 10:21 ` Benjamin Herrenschmidt
2014-12-12 5:30 ` Michael Ellerman
2014-12-09 13:18 ` Neelesh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209085435.GA1154@katana \
--to=wsa@the-dreams.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=neelegup@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).