linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Neelesh Gupta <neelegup@linux.vnet.ibm.com>,
	linuxppc-dev@ozlabs.org, devicetree@vger.kernel.org,
	linux-i2c@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [v3] i2c: Driver to expose PowerNV platform i2c busses
Date: Tue,  9 Dec 2014 20:45:02 +1100 (AEDT)	[thread overview]
Message-ID: <20141209094503.100F81400DE@ozlabs.org> (raw)
In-Reply-To: <20141208063039.14356.34770.stgit@localhost.localdomain>

On Mon, 2014-08-12 at 06:36:16 UTC, Neelesh Gupta wrote:
> The patch exposes the available i2c busses on the PowerNV platform
> to the kernel and implements the bus driver to support i2c and
> smbus commands.
> The driver uses the platform device infrastructure to probe the busses
> on the platform and registers them with the i2c driver framework.

>  arch/powerpc/include/asm/opal.h                    |   29 ++
>  arch/powerpc/platforms/powernv/opal-wrappers.S     |    1 
>  arch/powerpc/platforms/powernv/opal.c              |   11 +

This had major conflicts in the above files.

I've fixed it up but please check I did it correctly:

  https://github.com/mpe/powerpc-merge/commits/pw/neelesh-i2c

It also doesn't build as a module:

  $ grep CONFIG_I2C_OPAL .config
  CONFIG_I2C_OPAL=m
  $ make ...
  ...
  ERROR: "opal_i2c_request" [drivers/i2c/busses/i2c-opal.ko] undefined!

cheers

  parent reply	other threads:[~2014-12-09  9:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08  6:36 [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses Neelesh Gupta
2014-12-08 20:13 ` Benjamin Herrenschmidt
2014-12-08 20:55   ` Wolfram Sang
2014-12-08 21:43     ` Benjamin Herrenschmidt
2014-12-09  8:54       ` Wolfram Sang
2014-12-09  9:43         ` Benjamin Herrenschmidt
2014-12-09  9:45 ` Michael Ellerman [this message]
2014-12-09 10:21   ` [v3] " Benjamin Herrenschmidt
2014-12-12  5:30     ` Michael Ellerman
2014-12-09 13:18   ` Neelesh Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209094503.100F81400DE@ozlabs.org \
    --to=mpe@ellerman.id.au \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=neelegup@linux.vnet.ibm.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).