From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/powernv: Print the M64 range information
Date: Fri, 12 Dec 2014 08:58:19 +1100 [thread overview]
Message-ID: <20141211215818.GA6584@shangw> (raw)
In-Reply-To: <20141211072901.GA9598@richard>
On Thu, Dec 11, 2014 at 03:29:01PM +0800, Wei Yang wrote:
>On Thu, Dec 11, 2014 at 09:40:30AM +1100, Gavin Shan wrote:
>>On Wed, Dec 10, 2014 at 10:29:37PM +0800, Wei Yang wrote:
>>>The M64 range information is missed, which would be helpful in debug.
>>>
>>>This patch print the M64 range information in the same format as M32.
s/print/prints
>>>
>>>Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
>>>---
>>> arch/powerpc/platforms/powernv/pci-ioda.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>>diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
>>>index 21c8b4d..34f1a27 100644
>>>--- a/arch/powerpc/platforms/powernv/pci-ioda.c
>>>+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
>>>@@ -369,6 +369,9 @@ static void __init pnv_ioda_parse_m64_window(struct pnv_phb *phb)
>>> phb->ioda.m64_segsize = phb->ioda.m64_size / phb->ioda.total_pe;
>>> phb->ioda.m64_base = pci_addr;
>>>
>>>+ printk(KERN_INFO " MEM64 0x%016llx..0x%016llx -> 0x%016llx\n",
>>>+ res->start, res->end, pci_addr);
>>>+
>>
>>Please output segment size if you think it's helpful as well.
>
>The M64 segment size is printed in pnv_pci_init_ioda_phb() line 2620.
>
Yes, it has been printed separately. So the change looks good to me
after you replace "printk(KERN_INFO ...)" with pr_info. Could you please
send updated version and include following line if you want:
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Thanks,
Gavin
next prev parent reply other threads:[~2014-12-11 21:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 14:29 [PATCH] powerpc/powernv: Print the M64 range information Wei Yang
2014-12-10 22:40 ` Gavin Shan
2014-12-11 7:29 ` Wei Yang
2014-12-11 21:58 ` Gavin Shan [this message]
2014-12-12 4:28 ` Wei Yang
2014-12-12 4:39 ` [PATCH] powerpc/powernv: Print the M64 range information in bootup log Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211215818.GA6584@shangw \
--to=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).