From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B7941A020A for ; Sun, 14 Dec 2014 21:06:00 +1100 (AEDT) In-Reply-To: <1418151413-6141-5-git-send-email-shreyas@linux.vnet.ibm.com> To: "Shreyas B. Prabhu" , linux-kernel@vger.kernel.org From: Michael Ellerman Subject: Re: [v4,4/4] powernv: powerpc: Add winkle support for offline cpus Message-Id: <20141214100600.3446B140119@ozlabs.org> Date: Sun, 14 Dec 2014 21:05:59 +1100 (AEDT) Cc: "Shreyas B. Prabhu" , linuxppc-dev@lists.ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2014-09-12 at 18:56:53 UTC, "Shreyas B. Prabhu" wrote: > Winkle is a deep idle state supported in power8 chips. A core enters > winkle when all the threads of the core enter winkle. In this state > power supply to the entire chiplet i.e core, private L2 and private L3 > is turned off. As a result it gives higher powersavings compared to > sleep. ... > diff --git a/arch/powerpc/platforms/powernv/subcore.h b/arch/powerpc/platforms/powernv/subcore.h > index 148abc9..604eb40 100644 > --- a/arch/powerpc/platforms/powernv/subcore.h > +++ b/arch/powerpc/platforms/powernv/subcore.h > @@ -15,4 +15,5 @@ > > #ifndef __ASSEMBLY__ > void split_core_secondary_loop(u8 *state); > +extern void update_subcore_sibling_mask(void); > #endif subcore.c isn't built for CONFIG_SMP=n, resulting in: setup.c:(.init.text+0x34b0): undefined reference to `.update_subcore_sibling_mask' I needed to add: +#else +static inline void update_subcore_sibling_mask(void) { }; +#endif /* CONFIG_SMP */ I also got quite a few conflicts, with this and the previous patch, mainly in the paca and asm-offsets. Please check I resolved them correctly: https://github.com/mpe/powerpc-merge/commits/test cheers