From: Michael Ellerman <mpe@ellerman.id.au>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Geoff Levand <geoff@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: cbe-oss-dev@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org,
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Subject: Re: arch: powerpc: platforms: ps3: repository.c: Remove unused function
Date: Mon, 22 Dec 2014 16:02:23 +1100 (AEDT) [thread overview]
Message-ID: <20141222050223.39FA91400E7@ozlabs.org> (raw)
In-Reply-To: <1419087601-4889-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sat, 2014-20-12 at 15:00:01 UTC, Rickard Strandqvist wrote:
> Remove the function ps3_repository_write_highmem_info() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
Actually it looks like everything under CONFIG_PS3_REPOSITORY_WRITE is unused,
and never was used.
We appreciate these sort of patches, but if you can dig a little deeper and
also work out why the code is unused that would be much more useful.
cheers
next prev parent reply other threads:[~2014-12-22 5:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 15:00 [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function Rickard Strandqvist
2014-12-22 5:02 ` Michael Ellerman [this message]
2014-12-22 17:26 ` Geoff Levand
2014-12-22 17:36 ` Nathan Whitehorn
2014-12-22 22:11 ` Rickard Strandqvist
2014-12-23 0:26 ` Michael Ellerman
2014-12-23 2:44 ` Geoff Levand
2014-12-23 5:52 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222050223.39FA91400E7@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).