linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers
@ 2014-12-30  0:13 Nicolin Chen
  2014-12-30 11:28 ` Mark Brown
  2014-12-30 11:29 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolin Chen @ 2014-12-30  0:13 UTC (permalink / raw)
  To: broonie
  Cc: alsa-devel, lgirdwood, festevam, Xiubo.Lee, timur, linux-kernel,
	a_bouin, linuxppc-dev

The xDC field should have 5 bit width according to Reference Manual.
Thus this patch fixes it.

Signed-off-by: Aurelien BOUIN <a_bouin@yahoo.fr>
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---

The patch was originally submitted by Aurelien BOUIN while in an
informal way. And he hasn't finished any re-submitting during the
past two weeks. Thus I create a new patch with his signed-off
included so as to fix the probelm as soon as possible, not sure
whether it's decent or not though.

--Nicolin

 sound/soc/fsl/fsl_esai.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/fsl/fsl_esai.h b/sound/soc/fsl/fsl_esai.h
index 91a550f..5e793bb 100644
--- a/sound/soc/fsl/fsl_esai.h
+++ b/sound/soc/fsl/fsl_esai.h
@@ -302,7 +302,7 @@
 #define ESAI_xCCR_xFP_MASK	(((1 << ESAI_xCCR_xFP_WIDTH) - 1) << ESAI_xCCR_xFP_SHIFT)
 #define ESAI_xCCR_xFP(v)	((((v) - 1) << ESAI_xCCR_xFP_SHIFT) & ESAI_xCCR_xFP_MASK)
 #define ESAI_xCCR_xDC_SHIFT     9
-#define ESAI_xCCR_xDC_WIDTH	4
+#define ESAI_xCCR_xDC_WIDTH	5
 #define ESAI_xCCR_xDC_MASK	(((1 << ESAI_xCCR_xDC_WIDTH) - 1) << ESAI_xCCR_xDC_SHIFT)
 #define ESAI_xCCR_xDC(v)	((((v) - 1) << ESAI_xCCR_xDC_SHIFT) & ESAI_xCCR_xDC_MASK)
 #define ESAI_xCCR_xPSR_SHIFT	8
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers
  2014-12-30  0:13 [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers Nicolin Chen
@ 2014-12-30 11:28 ` Mark Brown
  2014-12-30 11:29 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-12-30 11:28 UTC (permalink / raw)
  To: Nicolin Chen
  Cc: alsa-devel, lgirdwood, festevam, Xiubo.Lee, timur, linux-kernel,
	a_bouin, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

On Mon, Dec 29, 2014 at 04:13:51PM -0800, Nicolin Chen wrote:
> The xDC field should have 5 bit width according to Reference Manual.
> Thus this patch fixes it.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers
  2014-12-30  0:13 [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers Nicolin Chen
  2014-12-30 11:28 ` Mark Brown
@ 2014-12-30 11:29 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-12-30 11:29 UTC (permalink / raw)
  To: Nicolin Chen
  Cc: alsa-devel, lgirdwood, festevam, Xiubo.Lee, timur, linux-kernel,
	a_bouin, linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

On Mon, Dec 29, 2014 at 04:13:51PM -0800, Nicolin Chen wrote:
> The xDC field should have 5 bit width according to Reference Manual.
> Thus this patch fixes it.

Applied, thanks - I also fixed the patch author up to be him.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-30 11:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-30  0:13 [PATCH] ASoC: fsl_esai: Fix incorrect xDC field width of xCCR registers Nicolin Chen
2014-12-30 11:28 ` Mark Brown
2014-12-30 11:29 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).