From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cdptpa-oedge-vip.email.rr.com (cdptpa-outbound-snat.email.rr.com [107.14.166.227]) by lists.ozlabs.org (Postfix) with ESMTP id 8BBEF1A083A for ; Wed, 7 Jan 2015 04:55:33 +1100 (AEDT) Date: Tue, 6 Jan 2015 12:48:22 -0500 From: Steven Rostedt To: Anton Blanchard Subject: Re: [PATCH 1/2] jump_label: Allow jump labels to be used in assembly Message-ID: <20150106174822.GA29629@home.goodmis.org> References: <1420539628-17875-1-git-send-email-anton@samba.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1420539628-17875-1-git-send-email-anton@samba.org> Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, jbaron@akamai.com, paulus@samba.org, mgorman@suse.de, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, mingo@kernel.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jan 06, 2015 at 09:20:27PM +1100, Anton Blanchard wrote: > To use jump labels in assembly we need the HAVE_JUMP_LABEL define, > so we select a fallback version if the toolchain does not support > them. > > Modify linux/jump_label.h so it can be included by assembly files. > We also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS. > > Signed-off-by: Anton Blanchard > --- > Makefile | 1 + > include/linux/jump_label.h | 21 +++++++++++++++++---- > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index ef748e1..7b83c3f 100644 > --- a/Makefile > +++ b/Makefile > @@ -774,6 +774,7 @@ KBUILD_ARFLAGS := $(call ar-option,D) > # check for 'asm goto' > ifeq ($(shell $(CONFIG_SHELL) $(srctree)/scripts/gcc-goto.sh $(CC)), y) > KBUILD_CFLAGS += -DCC_HAVE_ASM_GOTO > + KBUILD_AFLAGS += -DCC_HAVE_ASM_GOTO > endif > > include $(srctree)/scripts/Makefile.extrawarn > diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h > index 98f923b6..f4de473 100644 > --- a/include/linux/jump_label.h > +++ b/include/linux/jump_label.h > @@ -45,6 +45,12 @@ > * same as using STATIC_KEY_INIT_FALSE. > */ > > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) > +# define HAVE_JUMP_LABEL > +#endif > + > +#ifndef __ASSEMBLY__ > + > #include > #include > #include > @@ -55,7 +61,7 @@ extern bool static_key_initialized; > "%s used before call to jump_label_init", \ > __func__) > > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) > +#ifdef HAVE_JUMP_LABEL > > struct static_key { > atomic_t enabled; > @@ -66,13 +72,18 @@ struct static_key { > #endif > }; > > -# include > -# define HAVE_JUMP_LABEL > #else > struct static_key { > atomic_t enabled; > }; > -#endif /* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */ > +#endif /* HAVE_JUMP_LABEL */ > +#endif /* __ASSEMBLY__ */ > + > +#ifdef HAVE_JUMP_LABEL > +#include > +#endif Have you tested this on other archs? Because just looking at x86, it doesn't seem that asm/jump_label.h can handle being called in assembly. -- Steve > + > +#ifndef __ASSEMBLY__ > > enum jump_label_type { > JUMP_LABEL_DISABLE = 0, > @@ -203,3 +214,5 @@ static inline bool static_key_enabled(struct static_key *key) > } > > #endif /* _LINUX_JUMP_LABEL_H */ > + > +#endif /* __ASSEMBLY__ */ > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/