From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 02/11] i2c: add quirk checks to core
Date: Mon, 12 Jan 2015 11:13:49 +0100 [thread overview]
Message-ID: <20150112101349.GA995@katana> (raw)
In-Reply-To: <20150112095847.GD3625@ldesroches-Latitude-E6320>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
> I am not sure it will perfectly fit at91 quirks.
I think it does.
> The hardware can handle two messages by using the internal address
> feature. The internal address size is from one byte to three bytes. Then
> the length of the first message is limited to three but we don't have
> this constraint for the second one. If we have 'write then read' no problem
> but if we have two write messages, the second one will cause a quirk
> exceeded error.
Yeah, for this reason I seperated I2C_ADAPTER_QUIRK_COMB_WRITE_FIRST
out. The first message is checked against max_comb_write_len which is
set to 3 for your driver. The second is checked agains max_write_len
which is unset in your driver and thus can be of any length.
That should work, no?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-12 10:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 17:21 [RFC 00/11] i2c: add generic quirk infrastructure Wolfram Sang
2015-01-09 17:21 ` [RFC 01/11] i2c: add quirk structure to describe adapter flaws Wolfram Sang
2015-01-16 5:50 ` Eddie Huang
2015-01-19 15:05 ` Wolfram Sang
2015-02-24 16:04 ` Wolfram Sang
2015-01-16 8:18 ` Yingjoe Chen
2015-01-19 15:00 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 02/11] i2c: add quirk checks to core Wolfram Sang
2015-01-09 19:35 ` Sergei Shtylyov
2015-01-09 20:45 ` Wolfram Sang
2015-01-09 21:05 ` Sergei Shtylyov
2015-01-12 9:58 ` Ludovic Desroches
2015-01-12 10:13 ` Wolfram Sang [this message]
2015-01-12 12:08 ` Russell King - ARM Linux
2015-02-24 14:25 ` Wolfram Sang
2015-01-12 13:15 ` Matthias Brugger
2015-02-24 14:16 ` Wolfram Sang
2015-01-09 17:21 ` [RFC 03/11] i2c: at91: make use of the new infrastructure for quirks Wolfram Sang
2015-01-09 17:21 ` [RFC 04/11] i2c: opal: " Wolfram Sang
2015-01-09 17:21 ` [RFC 05/11] i2c: qup: " Wolfram Sang
2015-01-09 17:21 ` [RFC 06/11] i2c: cpm: " Wolfram Sang
2015-01-09 17:21 ` [RFC 07/11] i2c: axxia: " Wolfram Sang
2015-01-09 17:21 ` [RFC 08/11] i2c: dln2: " Wolfram Sang
2015-01-09 17:21 ` [RFC 09/11] i2c: powermac: " Wolfram Sang
2015-01-09 17:21 ` [RFC 10/11] i2c: viperboard: " Wolfram Sang
2015-01-09 17:21 ` [RFC 11/11] i2c: pmcmsp: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112101349.GA995@katana \
--to=wsa@the-dreams.de \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).