[PATCH] powerpc/fsl: Add empty ranges to etsec2 dts files

[PATCH] powerpc/fsl: Add empty ranges to etsec2 dts files

[Martin Hicks]

With an earlier change (746c9e9f - Fix PowerPC address parsing hack), ethernet
has broken on Freescale boards such as the P1022.  All ranges used by the
ethernet controllers are also covered by sub-devices that properly
declared the used ranges.  The error shown is:

fsl-gianfar: probe of soc@ffe00000:ethernet@b0000 failed with error -12

Signed-off-by: Martin Hicks <mort@bork.org>
---
 arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    1 +
 arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi |    1 +
 arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi |    1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
index 1382fec..d1a6c48 100644
--- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
+++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
@@ -43,6 +43,7 @@ mdio@24000 {
 ethernet@b0000 {
 	#address-cells = <1>;
 	#size-cells = <1>;
+	ranges = <>;
 	device_type = "network";
 	model = "eTSEC";
 	compatible = "fsl,etsec2";
diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi b/arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi
index 221cd2e..0447d38 100644
--- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi
+++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi
@@ -43,6 +43,7 @@ mdio@25000 {
 ethernet@b1000 {
 	#address-cells = <1>;
 	#size-cells = <1>;
+	ranges = <>;
 	device_type = "network";
 	model = "eTSEC";
 	compatible = "fsl,etsec2";
diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi b/arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi
index 61456c3..d2b7255 100644
--- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi
+++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi
@@ -42,6 +42,7 @@ mdio@26000 {
 ethernet@b2000 {
 	#address-cells = <1>;
 	#size-cells = <1>;
+	ranges = <>;
 	device_type = "network";
 	model = "eTSEC";
 	compatible = "fsl,etsec2";
-- 
1.7.10.4

Re: [PATCH] powerpc/fsl: Add empty ranges to etsec2 dts files

[Scott Wood]

On Mon, 2015-01-12 at 10:27 -0500, Martin Hicks wrote:
> 
> With an earlier change (746c9e9f - Fix PowerPC address parsing hack), ethernet
> has broken on Freescale boards such as the P1022.  All ranges used by the
> ethernet controllers are also covered by sub-devices that properly
> declared the used ranges.  The error shown is:
> 
> fsl-gianfar: probe of soc@ffe00000:ethernet@b0000 failed with error -12
> 
> Signed-off-by: Martin Hicks <mort@bork.org>
> ---
>  arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    1 +
>  arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi |    1 +
>  arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi |    1 +
>  3 files changed, 3 insertions(+)

http://patchwork.ozlabs.org/patch/422446/

> diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> index 1382fec..d1a6c48 100644
> --- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> @@ -43,6 +43,7 @@ mdio@24000 {
>  ethernet@b0000 {
>  	#address-cells = <1>;
>  	#size-cells = <1>;
> +	ranges = <>;

The " = <>" is usually omitted for empty properties.

-Scott

Re: [PATCH] powerpc/fsl: Add empty ranges to etsec2 dts files

[Martin Hicks]

[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

Perfect.  I'm glad there's a patch.
mh

On Mon, Jan 12, 2015 at 4:31 PM, Scott Wood <scottwood@freescale.com> wrote:

> On Mon, 2015-01-12 at 10:27 -0500, Martin Hicks wrote:
> >
> > With an earlier change (746c9e9f - Fix PowerPC address parsing hack),
> ethernet
> > has broken on Freescale boards such as the P1022.  All ranges used by the
> > ethernet controllers are also covered by sub-devices that properly
> > declared the used ranges.  The error shown is:
> >
> > fsl-gianfar: probe of soc@ffe00000:ethernet@b0000 failed with error -12
> >
> > Signed-off-by: Martin Hicks <mort@bork.org>
> > ---
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    1 +
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi |    1 +
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi |    1 +
> >  3 files changed, 3 insertions(+)
>
> http://patchwork.ozlabs.org/patch/422446/
>
> > diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > index 1382fec..d1a6c48 100644
> > --- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > @@ -43,6 +43,7 @@ mdio@24000 {
> >  ethernet@b0000 {
> >       #address-cells = <1>;
> >       #size-cells = <1>;
> > +     ranges = <>;
>
> The " = <>" is usually omitted for empty properties.
>
> -Scott
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>



-- 
Martin Hicks P.Eng.      |         mort@bork.org
Bork Consulting Inc.     |   +1 (613) 266-2296

[-- Attachment #2: Type: text/html, Size: 2716 bytes --]

Re: [PATCH] powerpc/fsl: Add empty ranges to etsec2 dts files

[jeclark2006]

[-- Attachment #1: Type: text/plain, Size: 2908 bytes --]

This was a sort of unfortunate revelation on how things ‘change’.

While as it is, I found this problem, and ‘fixed’ my device tree source, had this been for units ‘fielded’, I have to sleuth through some amount of kernel
code to find where the OF tree was parsed, and then ‘fix’ the kernel, as changing the FDT eeprom image is not really a ‘good’ option for
units that are in use, and need a firmware update.

John Clark.


On Jan 14, 2015, at 12:35 PM, Martin Hicks [via linuxppc] <ml-node+s10917n88773h8@n7.nabble.com> wrote:

> Perfect.  I'm glad there's a patch.
> mh
> 
> On Mon, Jan 12, 2015 at 4:31 PM, Scott Wood <[hidden email]> wrote:
> On Mon, 2015-01-12 at 10:27 -0500, Martin Hicks wrote:
> >
> > With an earlier change (746c9e9f - Fix PowerPC address parsing hack), ethernet
> > has broken on Freescale boards such as the P1022.  All ranges used by the
> > ethernet controllers are also covered by sub-devices that properly
> > declared the used ranges.  The error shown is:
> >
> > fsl-gianfar: probe of soc@ffe00000:ethernet@b0000 failed with error -12
> >
> > Signed-off-by: Martin Hicks <[hidden email]>
> > ---
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi |    1 +
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-1.dtsi |    1 +
> >  arch/powerpc/boot/dts/fsl/pq3-etsec2-2.dtsi |    1 +
> >  3 files changed, 3 insertions(+)
> 
> http://patchwork.ozlabs.org/patch/422446/
> 
> > diff --git a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > index 1382fec..d1a6c48 100644
> > --- a/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/pq3-etsec2-0.dtsi
> > @@ -43,6 +43,7 @@ mdio@24000 {
> >  ethernet@b0000 {
> >       #address-cells = <1>;
> >       #size-cells = <1>;
> > +     ranges = <>;
> 
> The " = <>" is usually omitted for empty properties.
> 
> -Scott
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> [hidden email]
> https://lists.ozlabs.org/listinfo/linuxppc-dev
> 
> 
> 
> -- 
> Martin Hicks P.Eng.      |         [hidden email]
> Bork Consulting Inc.     |   +1 (613) 266-2296
> 
> _______________________________________________ 
> Linuxppc-dev mailing list 
> [hidden email] 
> https://lists.ozlabs.org/listinfo/linuxppc-dev 
> 
> If you reply to this email, your message will be added to the discussion below:
> http://linuxppc.10917.n7.nabble.com/PATCH-powerpc-fsl-Add-empty-ranges-to-etsec2-dts-files-tp88699p88773.html
> To start a new topic under linuxppc-dev, email ml-node+s10917n3h38@n7.nabble.com 
> To unsubscribe from linuxppc, click here.
> NAML





--
View this message in context: http://linuxppc.10917.n7.nabble.com/PATCH-powerpc-fsl-Add-empty-ranges-to-etsec2-dts-files-tp88699p88774.html
Sent from the linuxppc-dev mailing list archive at Nabble.com.

[-- Attachment #2: Type: text/html, Size: 6657 bytes --]