From: Oleg Nesterov <oleg@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-arch@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, xen-devel@lists.xenproject.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE
Date: Thu, 15 Jan 2015 20:38:39 +0100 [thread overview]
Message-ID: <20150115193839.GA28727@redhat.com> (raw)
In-Reply-To: <1421312314-72330-5-git-send-email-borntraeger@de.ibm.com>
On 01/15, Christian Borntraeger wrote:
>
> --- a/arch/x86/include/asm/spinlock.h
> +++ b/arch/x86/include/asm/spinlock.h
> @@ -186,7 +186,7 @@ static inline void arch_spin_unlock_wait(arch_spinlock_t *lock)
> __ticket_t head = ACCESS_ONCE(lock->tickets.head);
>
> for (;;) {
> - struct __raw_tickets tmp = ACCESS_ONCE(lock->tickets);
> + struct __raw_tickets tmp = READ_ONCE(lock->tickets);
Agreed, but what about another ACCESS_ONCE() above?
Oleg.
next prev parent reply other threads:[~2015-01-15 19:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 8:58 [PATCH 0/8] current ACCESS_ONCE patch queue Christian Borntraeger
2015-01-15 8:58 ` [PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE Christian Borntraeger
2015-01-15 23:09 ` Michael Ellerman
2015-01-16 9:43 ` Christian Borntraeger
2015-01-15 8:58 ` [PATCH 2/8] ppc/hugetlbfs: " Christian Borntraeger
2015-01-15 8:58 ` [PATCH 3/8] x86/xen/p2m: " Christian Borntraeger
2015-01-15 9:26 ` Jürgen Groß
2015-01-15 10:43 ` [Xen-devel] " David Vrabel
2015-01-15 11:07 ` Christian Borntraeger
2015-01-15 8:58 ` [PATCH 4/8] x86/spinlock: Leftover conversion ACCESS_ONCE->READ_ONCE Christian Borntraeger
2015-01-15 19:38 ` Oleg Nesterov [this message]
2015-01-15 19:51 ` Christian Borntraeger
2015-01-15 20:01 ` Oleg Nesterov
2015-01-15 21:00 ` Christian Borntraeger
2015-01-15 8:58 ` [PATCH 5/8] mm/gup: Replace ACCESS_ONCE with READ_ONCE Christian Borntraeger
2015-01-15 8:58 ` [PATCH 6/8] kernel: tighten rules for ACCESS ONCE Christian Borntraeger
2015-01-15 8:58 ` [PATCH 7/8] next: sh: Fix compile error Christian Borntraeger
2015-01-15 8:58 ` [PATCH 8/8] kernel: Fix sparse warning for ACCESS_ONCE Christian Borntraeger
2015-01-16 12:12 ` [PATCH 0/8] current ACCESS_ONCE patch queue Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115193839.GA28727@redhat.com \
--to=oleg@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).