From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: powerpc/powernv: Don't alloc IRQ map if necessary
Date: Thu, 22 Jan 2015 17:22:48 +1100 [thread overview]
Message-ID: <20150122062248.GA18874@shangw> (raw)
In-Reply-To: <20150122055459.A5B3C140281@ozlabs.org>
On Thu, Jan 22, 2015 at 04:54:59PM +1100, Michael Ellerman wrote:
>On Thu, 2015-08-01 at 05:42:32 UTC, Gavin Shan wrote:
>> On PowerNV platform, the OPAL interrupts are exported by firmware
>> through device-node property (/ibm,opal::opal-interrupts). Under
>> some extreme circumstances (e.g. simulator), we don't have this
>> property found from the device tree. For that case, we shouldn't
>> allocate the interrupt map. Otherwise, slab complains allocating
>> zero sized memory chunk.
>
>That sounds fine. But the implementation is a bit messy.
>
>Can you do a precursor patch which moves the logic into opal_irq_init(), that
>way when you find no interrupts you can just return.
>
Sure, I'll change the code accordingly and repost.
Thanks,
Gavin
>cheers
>
prev parent reply other threads:[~2015-01-22 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 5:42 [PATCH] powerpc/powernv: Don't alloc IRQ map if necessary Gavin Shan
2015-01-22 5:54 ` Michael Ellerman
2015-01-22 6:22 ` Gavin Shan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122062248.GA18874@shangw \
--to=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).