From: Anton Blanchard <anton@samba.org>
To: Robert Richter <rric@kernel.org>
Cc: x86@kernel.org, mingo@redhat.com, paulus@samba.org,
hpa@zytor.com, oprofile-list@lists.sf.net, tglx@linutronix.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER
Date: Thu, 22 Jan 2015 22:31:00 +1100 [thread overview]
Message-ID: <20150122223100.1d234565@kryten> (raw)
In-Reply-To: <20150121182015.GA4201@rric.localhost>
Hi Robert,
> I also don't see a reason, why you don't want to support oprofile NMI
> timer. Is there any?
I couldn't come up with a case where it would be a benefit to us. We
roll out PMU support for a new CPU early so that the kernel and tools
support it when we GA. On the other hand adding oprofile NMI support
will put pressure on us to add more test cases.
> If you don't want NMI_TIMER being enabled, then (order of preference):
>
> * disable it with oprofile (OPROFILE dependency needed for
> NMI_TIMER), or
>
> * make the default value for NMI_TIMER !PPC64 and add a prompt to let
> the user select/deselect it, or
>
> * disable OPROFILE_NMI_TIMER by adding a !PPC64 dependency.
I'll rework and resubmit. Thanks.
Anton
prev parent reply other threads:[~2015-01-22 11:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 3:46 [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER Anton Blanchard
2015-01-21 3:46 ` [PATCH 2/2] powerpc: Add ppc64 hard lockup detector support Anton Blanchard
2015-01-21 11:54 ` [PATCH 1/2] oprofile: Add HAVE_OPROFILE_NMI_TIMER Anton Blanchard
2015-01-21 18:20 ` Robert Richter
2015-01-22 11:31 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150122223100.1d234565@kryten \
--to=anton@samba.org \
--cc=hpa@zytor.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=oprofile-list@lists.sf.net \
--cc=paulus@samba.org \
--cc=rric@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).