linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Tom Huynh <tommy.xhuynh@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Tom Huynh <tom.huynh@freescale.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linuxppc-dev@lists.ozlabs.org, acme@kernel.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com, paulus@samba.org,
	Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/3] perf/e6500: Make event translations available in sysfs
Date: Mon, 16 Feb 2015 10:10:45 -0600	[thread overview]
Message-ID: <20150216161045.GA32564@rivendell> (raw)
In-Reply-To: <20150209204019.GA13991@two.firstfloor.org>

On Mon, Feb 09, 2015 at 09:40:19PM +0100, Andi Kleen wrote:
> > I'll NAK any external 'download area' (and I told that Andi 
> > before): tools/perf/event-tables/ or so is a good enough 
> > 'download area' with fast enough update cycles.
> 
> The proposal was to put it on kernel.org, similar to how
> external firmware blobs are distributed. CPU event lists
> are data sheets, so are like firmware. They do not
> follow the normal kernel code licenses. They are not 
> source code. They cannot be reviewed in the normal way.
 
Could you provide more details about the license and review 
concern? How are the event list files different from hardware-
specific information (e.g. reg mapping) in header files?

> > If any 'update' of event descriptions is needed it can 
> > happen through the distro package mechanism, or via a 
> > simple 'git pull' if it's compiled directly.
> > 
> > Lets not overengineer this with any dependence on an 
> > external site and with a separate update mechanism - lets 
> > just get the tables into tools/ and see it from there...
> 
> That experiment has been already done for oprofile,
> didn't work very well.

Please excuse my ignorance, could you say exactly what didn't
work well for oprofile?

Ingo's suggestion seems good to me because these event files 
will be transparent to the users, and it's just more 
convenient not having to go to a website to look for 
the event file that matches the machine to download.
The distro package or the perf make mechanism can put these
files into the appropriate directory. The users who are not
perf developers won't need to know about these files.

- Tom

  parent reply	other threads:[~2015-02-16 16:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06 22:43 [PATCH 0/3] Add e6500 perf events to sysfs and update perf doc Tom Huynh
2015-02-06 22:43 ` [PATCH 1/3] perf/e6500: Make event translations available in sysfs Tom Huynh
2015-02-09 10:02   ` Peter Zijlstra
2015-02-09 10:07     ` Ingo Molnar
2015-02-09 12:11       ` Jiri Olsa
2015-02-09 13:25         ` Ingo Molnar
2015-02-09 20:40           ` Andi Kleen
2015-02-11  0:19             ` Scott Wood
2015-02-18 20:56               ` Ingo Molnar
2015-02-18 21:31                 ` Andi Kleen
2015-02-16 16:10             ` Tom Huynh [this message]
2015-03-27 21:34               ` Kim Phillips
2015-03-28  0:32                 ` Andi Kleen
2015-02-06 22:43 ` [PATCH 2/3] perf/e6500: Create a sysfs format entry for e6500 events Tom Huynh
2015-02-06 22:43 ` [PATCH 3/3] perf/doc: Update perf_event_attr struct Tom Huynh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150216161045.GA32564@rivendell \
    --to=tommy.xhuynh@gmail.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tom.huynh@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).