linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Paul Clarke <pc@us.ibm.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	linux-kernel@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2] powerpc: re-enable dynticks
Date: Fri, 20 Feb 2015 21:18:45 -0800	[thread overview]
Message-ID: <20150221051845.GS5745@linux.vnet.ibm.com> (raw)
In-Reply-To: <54E76B3D.1010909@us.ibm.com>

On Fri, Feb 20, 2015 at 11:13:33AM -0600, Paul Clarke wrote:
> 
> implement arch_irq_work_has_interrupt() for powerpc
> 
> (resending because I messed up the e-mail addresses)
> 
> Commit 9b01f5bf3 introduced a dependency on "IRQ work self-IPIs" for
> full dynamic ticks to be enabled, by expecting architectures to
> implement a suitable arch_irq_work_has_interrupt() routine.
> 
> Several arches have implemented this routine, including x86
> (3010279f) and arm (09f6edd4), but powerpc was omitted.
> 
> This patch implements this routine for powerpc.
> 
> The symptom, at boot (on powerpc arch systems) with "nohz_full=<CPU
> list>" is displayed:
>     NO_HZ: Can't run full dynticks because arch doesn't support irq
> work self-IPIs
> 
> after this patch:
>     NO_HZ: Full dynticks CPUs: <CPU list>.
> 
> Tested against 3.19.
> 
> v2: changed "return 1" to "return true", per Michael Ellerman
> 
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Paul A. Clarke <pc@us.ibm.com>

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> diff --git a/arch/powerpc/include/asm/irq_work.h
> b/arch/powerpc/include/asm/irq_work.h
> new file mode 100644
> index 0000000..99cc0aa
> --- /dev/null
> +++ b/arch/powerpc/include/asm/irq_work.h
> @@ -0,0 +1,11 @@
> +#ifndef _ASM_IRQ_WORK_H
> +#define _ASM_IRQ_WORK_H
> +
> +#include <asm/processor.h>
> +
> +static inline bool arch_irq_work_has_interrupt(void)
> +{
> +    return true;
> +}
> +
> +#endif /* _ASM_IRQ_WORK_H */

  reply	other threads:[~2015-02-21  5:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 19:38 [PATCH] powerpc: re-enable dynticks Paul Clarke
2015-02-13 20:42 ` Paul E. McKenney
2015-02-16  0:08 ` Michael Ellerman
2015-02-16  4:06   ` Benjamin Herrenschmidt
2015-02-22 22:13     ` Frederic Weisbecker
2015-02-22 22:30       ` Benjamin Herrenschmidt
2015-02-20 17:08   ` [PATCH v2] " Paul Clarke
2015-02-20 17:13   ` Paul Clarke
2015-02-21  5:18     ` Paul E. McKenney [this message]
2015-02-27 13:27       ` Paul Clarke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150221051845.GS5745@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=pc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).