From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.arm.linux.org.uk (pandora.arm.linux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 5765B1A32AA for ; Tue, 10 Mar 2015 01:51:28 +1100 (AEDT) Date: Mon, 9 Mar 2015 14:51:02 +0000 From: Russell King - ARM Linux To: Kees Cook Subject: Re: [PATCH 5/5] mm: fold arch_randomize_brk into ARCH_HAS_ELF_RANDOMIZE Message-ID: <20150309145101.GO8656@n2100.arm.linux.org.uk> References: <1425341988-1599-1-git-send-email-keescook@chromium.org> <1425341988-1599-6-git-send-email-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1425341988-1599-6-git-send-email-keescook@chromium.org> Sender: Russell King - ARM Linux Cc: linux-mips@linux-mips.org, Arun Chandran , Catalin Marinas , Heiko Carstens , Oleg Nesterov , Min-Hua Chen , Paul Mackerras , Yann Droneaud , linux-s390@vger.kernel.org, Andrey Ryabinin , x86@kernel.org, Hector Marco-Gisbert , "David A. Long" , Borislav Petkov , Ben Hutchings , Will Deacon , linux-fsdevel@vger.kernel.org, Alex Smith , Michael Holzheu , linux-arm-kernel@lists.infradead.org, Jeff Bailey , Paul Burton , linux-kernel@vger.kernel.org, Ralf Baechle , Andy Lutomirski , Vineeth Vijayan , Markos Chandras , Jan-Simon =?iso-8859-1?Q?M=F6ller?= , Martin Schwidefsky , linux390@de.ibm.com, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Alexander Viro List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Mar 02, 2015 at 04:19:48PM -0800, Kees Cook wrote: > diff --git a/arch/arm/include/asm/elf.h b/arch/arm/include/asm/elf.h > index afb9cafd3786..c1ff8ab12914 100644 > --- a/arch/arm/include/asm/elf.h > +++ b/arch/arm/include/asm/elf.h > @@ -125,10 +125,6 @@ int dump_task_regs(struct task_struct *t, elf_gregset_t *elfregs); > extern void elf_set_personality(const struct elf32_hdr *); > #define SET_PERSONALITY(ex) elf_set_personality(&(ex)) > > -struct mm_struct; > -extern unsigned long arch_randomize_brk(struct mm_struct *mm); > -#define arch_randomize_brk arch_randomize_brk > - > #ifdef CONFIG_MMU > #define ARCH_HAS_SETUP_ADDITIONAL_PAGES 1 > struct linux_binprm; Acked-by: Russell King -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.