From: Michael Ellerman <mpe@ellerman.id.au>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>
Cc: peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [2/9] powerpc/hv24x7: Remove unnecessary parameter
Date: Tue, 17 Mar 2015 11:13:52 +1100 (AEDT) [thread overview]
Message-ID: <20150317001352.69BC914010F@ozlabs.org> (raw)
In-Reply-To: <1424210434-28070-3-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, 2015-17-02 at 22:00:27 UTC, Sukadev Bhattiprolu wrote:
> Use pr_notice_ratelimited() to log error messages and remove
> the 'success_expected' parameter.
I don't understand how this is equivalent?
The current code uses success_expected to indicate that once it's done the
request once and found that it works, it then expects the request to continue
working, and if it doesn't then that is an error.
Using pr_ratelimited() will do the opposite, ie. the first failure will print a
message, but that may not really indicate an error, it may just be a badly
configured request.
Or at least that's how I understand it, please convince me I'm wrong :)
cheers
next prev parent reply other threads:[~2015-03-17 0:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 22:00 [PATCH 0/9] powerpc/hv-24x7: Reorganize single_24x7_request() Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 1/9] powerpc/hv-24x7: Modify definition of request and result buffers Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 2/9] powerpc/hv24x7: Remove unnecessary parameter Sukadev Bhattiprolu
2015-03-17 0:13 ` Michael Ellerman [this message]
2015-03-23 22:17 ` [2/9] " Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 3/9] powerpc/hv-24x7: Drop event_24x7_request() Sukadev Bhattiprolu
2015-03-17 2:16 ` [3/9] " Michael Ellerman
2015-02-17 22:00 ` [PATCH 4/9] powerpc/hv24x7: Move debug prints to separate function Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 5/9] powerpc/hv-24x7: Rename hv_24x7_event_update Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 6/9] powerpc/hv-24x7: Define add_event_to_24x7_request() Sukadev Bhattiprolu
2015-03-17 2:18 ` [6/9] " Michael Ellerman
2015-02-17 22:00 ` [PATCH 7/9] powerpc/hv-24x7: Define update_event_count() Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 8/9] powerpc/hv-24x7: Break up single_24x7_request Sukadev Bhattiprolu
2015-03-17 2:23 ` [8/9] " Michael Ellerman
2015-03-23 21:55 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 9/9] powerpc/hv-24x7: Add missing put_cpu_var() Sukadev Bhattiprolu
2015-03-17 2:39 ` [9/9] " Michael Ellerman
2015-03-23 21:47 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317001352.69BC914010F@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).