From: Michael Ellerman <mpe@ellerman.id.au>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>
Cc: peterz@infradead.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [6/9] powerpc/hv-24x7: Define add_event_to_24x7_request()
Date: Tue, 17 Mar 2015 13:18:07 +1100 (AEDT) [thread overview]
Message-ID: <20150317021807.A73A314011D@ozlabs.org> (raw)
In-Reply-To: <1424210434-28070-7-git-send-email-sukadev@linux.vnet.ibm.com>
On Tue, 2015-17-02 at 22:00:31 UTC, Sukadev Bhattiprolu wrote:
> Move code that maps a perf_event to a 24x7 request buffer into a
> separate function, add_event_to_24x7_request().
>
> diff --git a/arch/powerpc/perf/hv-24x7.c b/arch/powerpc/perf/hv-24x7.c
> index e78b127..76c649a 100644
> --- a/arch/powerpc/perf/hv-24x7.c
> +++ b/arch/powerpc/perf/hv-24x7.c
> @@ -1052,7 +1077,6 @@ static unsigned long single_24x7_request(struct perf_event *event, u64 *count)
> }
>
> resb = &result_buffer->results[0];
> -
> *count = be64_to_cpu(resb->elements[0].element_data[0]);
> out:
> return ret;
> @@ -1150,6 +1174,7 @@ static void h_24x7_event_read(struct perf_event *event)
> {
> s64 prev;
> u64 now;
> +
> now = h_24x7_get_value(event);
> prev = local64_xchg(&event->hw.prev_count, now);
> local64_add(now - prev, &event->count);
I'm a fan of whitespace for readability in cases like this, but do it as a
separate patch.
cheers
next prev parent reply other threads:[~2015-03-17 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 22:00 [PATCH 0/9] powerpc/hv-24x7: Reorganize single_24x7_request() Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 1/9] powerpc/hv-24x7: Modify definition of request and result buffers Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 2/9] powerpc/hv24x7: Remove unnecessary parameter Sukadev Bhattiprolu
2015-03-17 0:13 ` [2/9] " Michael Ellerman
2015-03-23 22:17 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 3/9] powerpc/hv-24x7: Drop event_24x7_request() Sukadev Bhattiprolu
2015-03-17 2:16 ` [3/9] " Michael Ellerman
2015-02-17 22:00 ` [PATCH 4/9] powerpc/hv24x7: Move debug prints to separate function Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 5/9] powerpc/hv-24x7: Rename hv_24x7_event_update Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 6/9] powerpc/hv-24x7: Define add_event_to_24x7_request() Sukadev Bhattiprolu
2015-03-17 2:18 ` Michael Ellerman [this message]
2015-02-17 22:00 ` [PATCH 7/9] powerpc/hv-24x7: Define update_event_count() Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 8/9] powerpc/hv-24x7: Break up single_24x7_request Sukadev Bhattiprolu
2015-03-17 2:23 ` [8/9] " Michael Ellerman
2015-03-23 21:55 ` Sukadev Bhattiprolu
2015-02-17 22:00 ` [PATCH 9/9] powerpc/hv-24x7: Add missing put_cpu_var() Sukadev Bhattiprolu
2015-03-17 2:39 ` [9/9] " Michael Ellerman
2015-03-23 21:47 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317021807.A73A314011D@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).