From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 4/5] powerpc/vphn: parsing code rewrite
Date: Tue, 17 Mar 2015 11:48:09 +0100 [thread overview]
Message-ID: <20150317114809.2be01a40@bahia.local> (raw)
In-Reply-To: <5507F8FA.7040004@linux.vnet.ibm.com>
On Tue, 17 Mar 2015 15:20:50 +0530
Anshuman Khandual <khandual@linux.vnet.ibm.com> wrote:
> > diff --git a/arch/powerpc/mm/vphn.h b/arch/powerpc/mm/vphn.h
> > index 96af9a4..fe8b780 100644
> > --- a/arch/powerpc/mm/vphn.h
> > +++ b/arch/powerpc/mm/vphn.h
> > @@ -6,10 +6,10 @@
> > #define VPHN_REGISTER_COUNT 6
> >
> > /*
> > - * 6 64-bit registers unpacked into 12 32-bit associativity values. To form
> > - * the complete property we have to add the length in the first cell.
> > + * 6 64-bit registers unpacked into up to 24 be32 associativity values. To
>
> I guess its be16 instead of be32 here ^^^^
The output array is supposed to mimic the ibm,associativity property in the
device tree. It is hence an array of be32 values, even if the hypervisor
passes them as be16 values.
Cheers.
--
Greg
next prev parent reply other threads:[~2015-03-17 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 15:14 [PATCH v3 0/5] VPHN parsing fixes Greg Kurz
2015-02-23 15:14 ` [PATCH v3 1/5] powerpc/vphn: clarify the H_HOME_NODE_ASSOCIATIVITY API Greg Kurz
2015-02-23 15:14 ` [PATCH v3 2/5] powerpc/vphn: move endianness fixing to vphn_unpack_associativity() Greg Kurz
2015-02-23 15:14 ` [PATCH v3 3/5] powerpc/vphn: move VPHN parsing logic to a separate file Greg Kurz
2015-02-23 15:14 ` [PATCH v3 4/5] powerpc/vphn: parsing code rewrite Greg Kurz
2015-03-17 9:50 ` Anshuman Khandual
2015-03-17 10:48 ` Greg Kurz [this message]
2015-02-23 15:14 ` [PATCH v3 5/5] selftests, powerpc: Add test for VPHN Greg Kurz
2015-03-17 4:21 ` [PATCH v4 5/5] selftests/powerpc: " Michael Ellerman
2015-03-17 11:49 ` Greg Kurz
2015-03-17 22:58 ` Michael Ellerman
2015-03-17 11:11 ` [PATCH v3 0/5] VPHN parsing fixes Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317114809.2be01a40@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).