From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 76B681A012C for ; Tue, 17 Mar 2015 21:48:19 +1100 (AEDT) Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Mar 2015 10:48:14 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id C0FA21B08061 for ; Tue, 17 Mar 2015 10:48:35 +0000 (GMT) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2HAmCCG10355180 for ; Tue, 17 Mar 2015 10:48:12 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2HAmBkh024885 for ; Tue, 17 Mar 2015 04:48:12 -0600 Date: Tue, 17 Mar 2015 11:48:09 +0100 From: Greg Kurz To: Anshuman Khandual Subject: Re: [PATCH v3 4/5] powerpc/vphn: parsing code rewrite Message-ID: <20150317114809.2be01a40@bahia.local> In-Reply-To: <5507F8FA.7040004@linux.vnet.ibm.com> References: <20150223151412.21565.2251.stgit@bahia.local> <20150223151437.21565.8231.stgit@bahia.local> <5507F8FA.7040004@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 17 Mar 2015 15:20:50 +0530 Anshuman Khandual wrote: > > diff --git a/arch/powerpc/mm/vphn.h b/arch/powerpc/mm/vphn.h > > index 96af9a4..fe8b780 100644 > > --- a/arch/powerpc/mm/vphn.h > > +++ b/arch/powerpc/mm/vphn.h > > @@ -6,10 +6,10 @@ > > #define VPHN_REGISTER_COUNT 6 > > > > /* > > - * 6 64-bit registers unpacked into 12 32-bit associativity values. To form > > - * the complete property we have to add the length in the first cell. > > + * 6 64-bit registers unpacked into up to 24 be32 associativity values. To > > I guess its be16 instead of be32 here ^^^^ The output array is supposed to mimic the ibm,associativity property in the device tree. It is hence an array of be32 values, even if the hypervisor passes them as be16 values. Cheers. -- Greg