From: David Miller <davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v6 0/3] Generic IOMMU pooled allocator
Date: Tue, 24 Mar 2015 18:16:17 -0400 (EDT) [thread overview]
Message-ID: <20150324.181617.1094177939652695812.davem@davemloft.net> (raw)
In-Reply-To: <cover.1427210772.git.sowmini.varadhan@oracle.com>
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Tue, 24 Mar 2015 13:10:27 -0400
> Deltas from patchv5:
> - removed iommu_tbl_ops, and instead pass the ->flush_all as
> an indirection to iommu_tbl_pool_init()
> - only invoke ->flush_all when there is no large_pool, based on
> the assumption that large-pool usage is infrequently encountered.
Generally this looks fine to me.
But about patch #2, I see no reason to have multiple iommu_pool_hash
tables. Even from a purely sparc perspective, we can always just do
with just one of them.
Furthermore, you can even probably move it down into lib/iommu-common.c
itself. iommu_tbl_pool_init() can do the one time initialization.
next prev parent reply other threads:[~2015-03-24 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 17:10 [PATCH v6 0/3] Generic IOMMU pooled allocator Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 2/3] sparc: Make sparc64 use scalable lib/iommu-common.c functions Sowmini Varadhan
2015-03-24 17:10 ` [PATCH v6 RFC 3/3] sparc: Make LDC use common iommu poll management functions Sowmini Varadhan
2015-03-24 22:16 ` David Miller [this message]
2015-03-25 17:36 ` [PATCH v6 0/3] Generic IOMMU pooled allocator Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324.181617.1094177939652695812.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aik@au1.ibm.com \
--cc=anton@au1.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).