From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: aik@au1.ibm.com, anton@au1.ibm.com, paulus@samba.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: Re: [PATCHv9 RFC 1/3] Break up monolithic iommu table/lock into finer graularity pools and lock
Date: Sun, 5 Apr 2015 15:17:06 -0400 [thread overview]
Message-ID: <20150405191706.GA19554@oracle.com> (raw)
In-Reply-To: <1428236761.20500.315.camel@kernel.crashing.org>
On (04/05/15 22:26), Benjamin Herrenschmidt wrote:
>
> So you decided to keep the logic here that updates the hint instead of
> just getting rid of need_flush alltogether ?
>
> Out of curiosity, what's the rationale ? Did you find a reason why
> resetting the hint in those two cases (rather than just setting "start"
> appropriately) is actually useful ?
To be honest, I actually did not want to poke at this too much, given
that both ppc and sparc seem to have essentially the same
logic.
But my gut feeling is that if the pool->hint hasn't resulted
in a succesful area_alloc, we might as well reset it for the next
iommu*range_alloc-er, because it's likely that the next alloc
will also need to wrap and search anyway..
--Sowmini
next prev parent reply other threads:[~2015-04-05 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 11:49 [PATCH v9 RFC 0/3] Generic IOMMU pooled allocator Sowmini Varadhan
2015-04-05 11:49 ` [PATCHv9 RFC 1/3] Break up monolithic iommu table/lock into finer graularity pools and lock Sowmini Varadhan
2015-04-05 12:26 ` Benjamin Herrenschmidt
2015-04-05 19:17 ` Sowmini Varadhan [this message]
2015-04-08 8:30 ` Benjamin Herrenschmidt
2015-04-08 10:12 ` Sowmini Varadhan
2015-04-05 11:49 ` [PATCH v9 RFC 2/3] sparc: Make sparc64 use scalable lib/iommu-common.c functions Sowmini Varadhan
2015-04-05 11:49 ` [PATCH v9 RFC 3/3] sparc: Make LDC use common iommu poll management functions Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150405191706.GA19554@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=aik@au1.ibm.com \
--cc=anton@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).