* [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c
@ 2015-04-28 0:42 Michael Ellerman
2015-04-28 4:36 ` Paul Mackerras
2015-04-28 7:51 ` Alexander Graf
0 siblings, 2 replies; 3+ messages in thread
From: Michael Ellerman @ 2015-04-28 0:42 UTC (permalink / raw)
To: linuxppc-dev; +Cc: warrier, Paul Mackerras, agraf
Commit 34cb7954c0aa "Convert ICS mutex lock to spin lock" added an
include of asm/spinlock.h, which does not work in the SMP=n case.
It should instead include linux/spinlock.h
Fixes: 34cb7954c0aa ("KVM: PPC: Book3S HV: Convert ICS mutex lock to spin lock")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
I'll drop this in my fixes branch for tomorrow unless someone objects.
arch/powerpc/kvm/book3s_xics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
index 8f3e6cc54d95..c6ca7db64673 100644
--- a/arch/powerpc/kvm/book3s_xics.c
+++ b/arch/powerpc/kvm/book3s_xics.c
@@ -12,6 +12,7 @@
#include <linux/err.h>
#include <linux/gfp.h>
#include <linux/anon_inodes.h>
+#include <linux/spinlock.h>
#include <asm/uaccess.h>
#include <asm/kvm_book3s.h>
@@ -20,7 +21,6 @@
#include <asm/xics.h>
#include <asm/debug.h>
#include <asm/time.h>
-#include <asm/spinlock.h>
#include <linux/debugfs.h>
#include <linux/seq_file.h>
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c
2015-04-28 0:42 [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c Michael Ellerman
@ 2015-04-28 4:36 ` Paul Mackerras
2015-04-28 7:51 ` Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mackerras @ 2015-04-28 4:36 UTC (permalink / raw)
To: Michael Ellerman; +Cc: warrier, linuxppc-dev, agraf
On Tue, Apr 28, 2015 at 10:42:47AM +1000, Michael Ellerman wrote:
> Commit 34cb7954c0aa "Convert ICS mutex lock to spin lock" added an
> include of asm/spinlock.h, which does not work in the SMP=n case.
>
> It should instead include linux/spinlock.h
>
> Fixes: 34cb7954c0aa ("KVM: PPC: Book3S HV: Convert ICS mutex lock to spin lock")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Paul Mackerras <paulus@samba.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c
2015-04-28 0:42 [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c Michael Ellerman
2015-04-28 4:36 ` Paul Mackerras
@ 2015-04-28 7:51 ` Alexander Graf
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Graf @ 2015-04-28 7:51 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev; +Cc: warrier, Paul Mackerras
On 28.04.15 02:42, Michael Ellerman wrote:
> Commit 34cb7954c0aa "Convert ICS mutex lock to spin lock" added an
> include of asm/spinlock.h, which does not work in the SMP=n case.
>
> It should instead include linux/spinlock.h
>
> Fixes: 34cb7954c0aa ("KVM: PPC: Book3S HV: Convert ICS mutex lock to spin lock")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Alexander Graf <agraf@suse.de>
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-28 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-28 0:42 [PATCH] powerpc/kvm: Fix SMP=n build error in book3s_xics.c Michael Ellerman
2015-04-28 4:36 ` Paul Mackerras
2015-04-28 7:51 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).