From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: weiyang@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
Date: Fri, 1 May 2015 11:28:40 +1000 [thread overview]
Message-ID: <20150501012840.GA12990@gwshan> (raw)
In-Reply-To: <1430437857.32679.2.camel@ellerman.id.au>
On Fri, May 01, 2015 at 09:50:57AM +1000, Michael Ellerman wrote:
>On Fri, 2015-05-01 at 09:22 +1000, Gavin Shan wrote:
>> Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
>> devices in early stage, which is reasonable to pSeries platform.
>> However, it's wrong for PowerNV platform because the PE# isn't
>> determined until the resources (IO and MMIO) are assigned to
>> PE in hotplug case. So we have to delay probing EEH devices
>> for PowerNV platform until the PE# is assigned.
>>
>> Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
>
>I don't have that SHA.
>
>I've have a commit with the same subject which is ff57b454ddb9.
>
>Is that the same thing?
>
Yes, they're same thing.
>I also have 89a51df5ab1d, which Fixes that commit (ff57..).
>
There seems something wrong at local because "git show 1c509148b" leads
me to the patch as well. However, I believe ff57b454ddb9 is the correct
one. I'll send v2 to fix it up.
---
gwshan@gwshan:~/sandbox/linux$ git show 1c509148b
1 commit 1c509148bd6b5199dc1d97e146eda496f9f22a06
2 Author: Gavin Shan <gwshan@linux.vnet.ibm.com>
3 Date: Tue Mar 17 10:49:45 2015 +1100
4
5 powerpc/eeh: Do probe on pci_dn
gwshan@gwshan:~/sandbox/linux$ git show ff57b454ddb9
1 commit ff57b454ddb938d98d48d8df356357000fedc88c
2 Author: Gavin Shan <gwshan@linux.vnet.ibm.com>
3 Date: Tue Mar 17 16:15:06 2015 +1100
4
5 powerpc/eeh: Do probe on pci_dn
Thanks,
Gavin
>cheers
>
>
next prev parent reply other threads:[~2015-05-01 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 23:22 [PATCH] powerpc/eeh: Delay probing EEH device during hotplug Gavin Shan
2015-04-30 23:50 ` Michael Ellerman
2015-05-01 1:28 ` Gavin Shan [this message]
2015-05-01 3:51 ` Michael Ellerman
2015-05-01 4:05 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150501012840.GA12990@gwshan \
--to=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox