From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 81D4E1A0008 for ; Tue, 12 May 2015 18:07:36 +1000 (AEST) Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 12 May 2015 18:07:34 +1000 Received: from d23relay09.au.ibm.com (d23relay09.au.ibm.com [9.185.63.181]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 59C4D357804C for ; Tue, 12 May 2015 18:07:33 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4C87PZc45613246 for ; Tue, 12 May 2015 18:07:33 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4C870Hl000425 for ; Tue, 12 May 2015 18:07:01 +1000 Date: Tue, 12 May 2015 16:06:43 +0800 From: Wei Yang To: Gavin Shan Subject: Re: [PATCH V3 6/9] powerpc/powernv: create/release eeh_dev for VF Message-ID: <20150512080643.GC16788@richard> Reply-To: Wei Yang References: <1430723258-21299-1-git-send-email-weiyang@linux.vnet.ibm.com> <1430723258-21299-7-git-send-email-weiyang@linux.vnet.ibm.com> <20150511024856.GB8816@gwshan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150511024856.GB8816@gwshan> Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, Wei Yang , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 11, 2015 at 12:48:56PM +1000, Gavin Shan wrote: >On Mon, May 04, 2015 at 03:07:35PM +0800, Wei Yang wrote: > >Please order this patch and PATCH[5] because EEH device is expected to >be created before EEH PE. > >>EEH on powerpc platform needs eeh_dev structure to track the pci device > ^^^ > PCI > >>status. Since VFs are created/released dynamically, VF's eeh_dev is also >>dynamically created/released in system. >> >>This patch creates/removes eeh_dev when pci_dn is created/removed for VFs, >>and marks it with EEH_DEV_VF type. >> >>Signed-off-by: Wei Yang >>--- >> arch/powerpc/include/asm/eeh.h | 7 +++++++ >> arch/powerpc/kernel/eeh.c | 4 ++++ >> arch/powerpc/kernel/eeh_dev.c | 20 ++++++++++++++++++++ >> arch/powerpc/kernel/pci_dn.c | 7 +++++++ >> 4 files changed, 38 insertions(+) >> >>diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h >>index 56e8cd9..2067de4 100644 >>--- a/arch/powerpc/include/asm/eeh.h >>+++ b/arch/powerpc/include/asm/eeh.h >>@@ -124,6 +124,7 @@ static inline bool eeh_pe_passed(struct eeh_pe *pe) >> #define EEH_DEV_NO_HANDLER (1 << 8) /* No error handler */ >> #define EEH_DEV_SYSFS (1 << 9) /* Sysfs created */ >> #define EEH_DEV_REMOVED (1 << 10) /* Removed permanently */ >>+#define EEH_DEV_VF (1 << 11) /* VF port */ >> > >Why you need this flag? I guess "edev->physfn" can be used to distinguish >it's a normal or VF eeh_dev. > Just like we have EEH_DEV_BRIDGE and EEH_DEV_DS_PORT, I use the flag EEH_DEV_VF to mark it a VF eeh_dev. -- Richard Yang Help you, Help me