From: Anton Blanchard <anton@samba.org>
To: Laurentiu Tudor <b10716@freescale.com>
Cc: <benh@kernel.crashing.org>, <paulus@samba.org>,
<mpe@ellerman.id.au>, <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/perf: Fix book3s kernel to userspace backtraces
Date: Tue, 26 May 2015 22:09:57 +1000 [thread overview]
Message-ID: <20150526220957.4bd69895@kryten> (raw)
In-Reply-To: <556433D2.4010102@freescale.com>
Hi Laurentiu,
> > + if ((TRAP(regs) == 0xf00) && regs->result)
> > + return true;
> > +
> > + return false;
>
> Why not just
>
> return (TRAP(regs) == 0xf00) && regs->result;
Could do, it just read a little easier to my tired eyes.
Anton
next prev parent reply other threads:[~2015-05-26 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 5:10 [PATCH] powerpc/perf: Fix book3s kernel to userspace backtraces Anton Blanchard
2015-05-26 8:50 ` Laurentiu Tudor
2015-05-26 12:09 ` Anton Blanchard [this message]
2015-05-26 23:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526220957.4bd69895@kryten \
--to=anton@samba.org \
--cc=b10716@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).