From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lists.ozlabs.org (Postfix) with ESMTP id CC6D71A0E5B for ; Thu, 28 May 2015 02:24:50 +1000 (AEST) Date: Wed, 27 May 2015 09:24:47 -0700 From: Andi Kleen To: Namhyung Kim Cc: Sukadev Bhattiprolu , Ingo Molnar , Michael Ellerman , Jiri Olsa , Arnaldo Carvalho de Melo , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/4] perf: Add power8 PMU events in JSON format Message-ID: <20150527162447.GN7484@tassilo.jf.intel.com> References: <1432080130-6678-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432080130-6678-5-git-send-email-sukadev@linux.vnet.ibm.com> <20150527135928.GB29557@danjae.kornet> <20150527144101.GM7484@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, May 28, 2015 at 12:01:31AM +0900, Namhyung Kim wrote: > On Wed, May 27, 2015 at 11:41 PM, Andi Kleen wrote: > >> > + { > >> > + "EventCode": "0x2505e", > >> > + "EventName": "PM_BACK_BR_CMPL", > >> > + "BriefDescription": "Branch instruction completed with a target address less than current instruction address,", > >> > + "PublicDescription": "Branch instruction completed with a target address less than current instruction address.," > >> > >> Can't we remove PublicDescription field if it's identical to > >> BriefDescription? It seems just wasting spaces.. > > > > It's not always identical. There are events where PublicDescription is much longer (several paragraphs) > > I know. What I said is make it optional so that we can drop if it's identical. Should be easy enough. It's already optional in the jevents parser. -Andi -- ak@linux.intel.com -- Speaking for myself only