linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Cc: <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [2/4,v3] powerpc/fsl-booke: Add T1024 QDS board support
Date: Thu, 28 May 2015 19:24:36 -0500	[thread overview]
Message-ID: <20150529002436.GA4248@home.buserror.net> (raw)
In-Reply-To: <1428566865-35732-2-git-send-email-Shengzhou.Liu@freescale.com>

On Thu, Apr 09, 2015 at 04:07:43PM +0800, Shengzhou Liu wrote:
> +			flash@2 {
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +				compatible = "eon,en25s64";   /* 8MB */
> +				reg = <2>;
> +				spi-max-frequency = <10000000>;
> +			};

AFAICT the vendor is phyton, not eon.

> +					eeprom@50 {
> +						compatible = "at24,24c512";
> +						reg = <0x50>;
> +					};
> +
> +					eeprom@51 {
> +						compatible = "at24,24c02";
> +						reg = <0x51>;
> +					};
> +
> +					eeprom@57 {
> +						compatible = "at24,24c02";
> +						reg = <0x57>;
> +					};

The vendor is atmel, not at24.

I'll fix when applying, but please be careful with compatible strings
next time.  Also, please document compatible strings and vendor prefixes
when checkpatch complains, unless it's a situation where checkpatch isn't
recognizing a pattern compatible (e.g.  "fsl,<soc>-whatever" or
"fsl,whatever-<version>").

This patch also had too long lines in the commit message (and really, you
don't need to describe the board in such detail).  I'll remove that
section of the changelog when applying.

-Scott

  reply	other threads:[~2015-05-29  0:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  8:07 [PATCH 1/4 v3] powerpc/fsl-booke: Add device tree support for T1024/T1023 SoC Shengzhou Liu
2015-04-09  8:07 ` [PATCH 2/4 v3] powerpc/fsl-booke: Add T1024 QDS board support Shengzhou Liu
2015-05-29  0:24   ` Scott Wood [this message]
2015-06-01  8:23     ` [2/4,v3] " Liu Shengzhou
2015-06-01 22:00       ` Scott Wood
2015-04-09  8:07 ` [PATCH 3/4 v3] powerpc/fsl-booke: Add T1024 RDB " Shengzhou Liu
2015-04-09  8:07 ` [PATCH 4/4 v3] powerpc/fsl-booke: Add T1023 " Shengzhou Liu
2015-05-29  0:30   ` [4/4,v3] " Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529002436.GA4248@home.buserror.net \
    --to=scottwood@freescale.com \
    --cc=Shengzhou.Liu@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).