From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e39.co.us.ibm.com (e39.co.us.ibm.com [32.97.110.160]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id D5CB41A0045 for ; Fri, 29 May 2015 15:45:44 +1000 (AEST) Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 28 May 2015 23:45:42 -0600 Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 28D6638C803B for ; Fri, 29 May 2015 01:45:39 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4T5jcgc60227754 for ; Fri, 29 May 2015 05:45:39 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4T5jcWr026085 for ; Fri, 29 May 2015 01:45:38 -0400 Date: Thu, 28 May 2015 22:45:06 -0700 From: Sukadev Bhattiprolu To: Jiri Olsa Cc: mingo@redhat.com, ak@linux.intel.com, Michael Ellerman , Arnaldo Carvalho de Melo , Paul Mackerras , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile Message-ID: <20150529054506.GA3088@us.ibm.com> References: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432761809-4344-5-git-send-email-sukadev@linux.vnet.ibm.com> <20150528124221.GK12392@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150528124221.GK12392@krava.redhat.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jiri Olsa [jolsa@redhat.com] wrote: | > if (line[0] == '#' || line[0] == '\n') | > continue; | > + if (!strncmp(line, "Family", 6)) | > + continue; | | I think we should fix mapfiles to put the 'Family' starting | line as a comment.. the way powerpc mapfile is done You mean add something like this to the Intel mapfile: # Power8 entries 004d0100,1,power8.json,core and drop this patch?