linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: mingo@redhat.com, ak@linux.intel.com,
	Michael Ellerman <mpe@ellerman.id.au>,
	Jiri Olsa <jolsa@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v13 09/14] perf, tools: Group alias perf list by section
Date: Tue, 2 Jun 2015 12:20:02 -0700	[thread overview]
Message-ID: <20150602192002.GB3978@us.ibm.com> (raw)
In-Reply-To: <1433265135-20426-10-git-send-email-sukadev@linux.vnet.ibm.com>


Please drop this patch. It was incorrectly included in the set.
Also, see the updated Patch 12/14.

Current set of patches are in the json-v13.1 branch:

	https://github.com/sukadev/linux/tree/json-v13.1

Sukadev

Sukadev Bhattiprolu [sukadev@linux.vnet.ibm.com] wrote:
| From: Andi Kleen <ak@linux.intel.com>
| 
| The first first element in an hardware event name defines the general
| area, usually the part of the micro architecture it is refering to.
| Group the perf list output by these sections by adding section headers.
| 
| Signed-off-by: Andi Kleen <ak@linux.intel.com>
| Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
| ---
|  tools/perf/util/pmu.c |   17 +++++++++++++++++
|  1 file changed, 17 insertions(+)
| 
| diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
| index 417333b..8d91fa7 100644
| --- a/tools/perf/util/pmu.c
| +++ b/tools/perf/util/pmu.c
| @@ -1039,6 +1039,8 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag)
|  	struct pair *aliases;
|  	int numdesc = 0;
|  	int columns = pager_get_columns();
| +	const char *last_section;
| +	int last_section_len;
| 
|  	pmu = NULL;
|  	len = 0;
| @@ -1086,6 +1088,8 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag)
|  		}
|  	}
|  	len = j;
| +	last_section = NULL;
| +	last_section_len = 0;
|  	qsort(aliases, len, sizeof(struct pair), cmp_pair);
|  	for (j = 0; j < len; j++) {
|  		if (name_only) {
| @@ -1093,8 +1097,21 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag)
|  			continue;
|  		}
|  		if (aliases[j].desc && !quiet_flag) {
| +			char *dot;
| +			char *name = aliases[j].name;
| +
|  			if (numdesc++ == 0)
|  				printf("\n");
| +			dot = strchr(name, '.');
| +			if (dot &&
| +				(!last_section ||
| +				 strncmp(last_section, name, last_section_len))) {
| +				last_section_len = dot - name;
| +				printf("%s%.*s:\n",
| +						last_section ? "\n" : "",
| +						last_section_len, name);
| +				last_section = name;
| +			}
|  			printf("  %-50s\n", aliases[j].name);
|  			printf("%*s", 8, "[");
|  			wordwrap(aliases[j].desc, 8, columns, 0);
| -- 
| 1.7.9.5
| 
| --
| To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
| the body of a message to majordomo@vger.kernel.org
| More majordomo info at  http://vger.kernel.org/majordomo-info.html
| Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2015-06-02 19:20 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-02 17:12 [PATCH V13 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 01/14] perf, tools: Add jsmn `jasmine' JSON parser Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 02/14] perf, tools, jevents: Program to convert JSON file to C style file Sukadev Bhattiprolu
2015-06-03 10:30   ` Jiri Olsa
2015-06-03 10:31   ` Jiri Olsa
2015-06-03 10:32   ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 03/14] perf, tools: Use pmu_events_map table to create event aliases Sukadev Bhattiprolu
2015-06-03 10:30   ` Jiri Olsa
2015-06-03 10:30   ` Jiri Olsa
2015-06-03 10:31   ` Jiri Olsa
2015-06-03 10:31   ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 04/14] perf, tools: Allow events with dot Sukadev Bhattiprolu
2015-06-03 10:32   ` Jiri Olsa
2015-06-16  9:28     ` Robert Richter
2015-06-02 17:12 ` [PATCH v13 05/14] perf, tools: Support CPU id matching for x86 v2 Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 06/14] perf, tools: Support alias descriptions Sukadev Bhattiprolu
2015-06-03 10:31   ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 07/14] perf, tools: Query terminal width and use in perf list Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 08/14] perf, tools: Add a --no-desc flag to " Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 09/14] perf, tools: Group alias perf list by section Sukadev Bhattiprolu
2015-06-02 19:20   ` Sukadev Bhattiprolu [this message]
2015-06-02 17:12 ` [PATCH v13 10/14] perf, tools: Add override support for event list CPUID Sukadev Bhattiprolu
2015-06-02 17:12 ` [PATCH v13 11/14] perf, tools: Support long descriptions with perf list -v Sukadev Bhattiprolu
2015-06-03 10:32   ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 12/14] perf, tools: Add support for event list topics Sukadev Bhattiprolu
2015-06-02 19:16   ` Sukadev Bhattiprolu
2015-06-03 10:32     ` Jiri Olsa
2015-06-03 12:57       ` Andi Kleen
2015-06-03 13:26         ` Arnaldo Carvalho de Melo
2015-06-03 14:25         ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 13/14] perf, tools: Handle header line in mapfile Sukadev Bhattiprolu
2015-06-03 10:32   ` Jiri Olsa
2015-06-02 17:12 ` [PATCH v13 14/14] perf, tools: Add README for the JSON/map files parsing Sukadev Bhattiprolu
2015-06-02 19:22 ` [PATCH V13 00/14] perf, tools: Add support for PMU events in JSON format Sukadev Bhattiprolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150602192002.GB3978@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).